Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift max_running into generic python driver #6027

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 1, 2023

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Wait for tests in CI to pass (see "checks" below)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured new behaviour is tested (opened GUI? screenshots? tried workflows?)
  • Commit history is consistent and clean, in line with the contribution guidelines.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution
    guidelines
    .

@andreas-el andreas-el self-assigned this Sep 1, 2023
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Sep 1, 2023
@andreas-el andreas-el force-pushed the refactor_queue_driver branch 4 times, most recently from 46c9144 to 3cd4a13 Compare September 6, 2023 08:11
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #6027 (494f2bc) into main (d4ac0b9) will increase coverage by 0.14%.
Report is 3 commits behind head on main.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #6027      +/-   ##
==========================================
+ Coverage   82.53%   82.67%   +0.14%     
==========================================
  Files         352      352              
  Lines       21899    21811      -88     
  Branches      826      817       -9     
==========================================
- Hits        18074    18033      -41     
+ Misses       3526     3482      -44     
+ Partials      299      296       -3     
Files Changed Coverage Δ
src/clib/lib/job_queue/queue_driver.cpp 88.23% <0.00%> (+10.99%) ⬆️
src/ert/job_queue/driver.py 97.95% <92.30%> (-2.05%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andreas-el andreas-el force-pushed the refactor_queue_driver branch 3 times, most recently from 494f2bc to cde0407 Compare September 6, 2023 14:13
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andreas-el andreas-el merged commit 89e8e13 into equinor:main Sep 7, 2023
40 checks passed
@andreas-el andreas-el deleted the refactor_queue_driver branch September 7, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants