Replace basemodel with dataclass in event.py #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering whether this one should include other occurrences of (py38-ert) [jparu@be-lx101262 ert]$ grep -irn "from pydantic import BaseModel"
src/ert/ensemble_evaluator/event.py:3:from pydantic import BaseModel
src/ert/ensemble_evaluator/snapshot.py:12:from pydantic import BaseModel
src/ert/_c_wrappers/analysis/configuration.py:5:from pydantic import BaseModel, conlist, root_validator, validator
src/ert/parsing/config_schema_item.py:5:from pydantic import BaseModel
src/ert/storage/local_storage.py:22:from pydantic import BaseModel
src/ert/storage/local_ensemble.py:13:from pydantic import BaseModel |
jonathan-eq
force-pushed
the
replace-basemodel-with-dataclass-in-eventpy
branch
from
c6492de
to
326e5e3
Compare
Replaced event classes based on Pydantic.BaseModel with @dateclass
jonathan-eq
force-pushed
the
replace-basemodel-with-dataclass-in-eventpy
branch
from
b8c7188
to
c7106aa
Compare
Codecov Report
@@ Coverage Diff @@
## main #5754 +/- ##
==========================================
- Coverage 80.49% 79.63% -0.87%
==========================================
Files 360 362 +2
Lines 22202 23177 +975
Branches 824 1399 +575
==========================================
+ Hits 17871 18456 +585
- Misses 4083 4347 +264
- Partials 248 374 +126
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
jonathan-eq
changed the title
jonathan-eq
added
good first issue
improvement
The other instances make use of class methods included with BaseModel |
berland
added
release-notes:maintenance
auto-merge was automatically disabled
September 21, 2023 07:51
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2813
Approach
Replaced event.py classes based on Pydantic.BaseModel with @dateclass
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.