-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace basemodel with dataclass in event.py #5754
Conversation
I'm wondering whether this one should include other occurrences of (py38-ert) [jparu@be-lx101262 ert]$ grep -irn "from pydantic import BaseModel"
src/ert/ensemble_evaluator/event.py:3:from pydantic import BaseModel
src/ert/ensemble_evaluator/snapshot.py:12:from pydantic import BaseModel
src/ert/_c_wrappers/analysis/configuration.py:5:from pydantic import BaseModel, conlist, root_validator, validator
src/ert/parsing/config_schema_item.py:5:from pydantic import BaseModel
src/ert/storage/local_storage.py:22:from pydantic import BaseModel
src/ert/storage/local_ensemble.py:13:from pydantic import BaseModel |
c6492de
to
326e5e3
Compare
Replaced event classes based on Pydantic.BaseModel with @dateclass
b8c7188
to
c7106aa
Compare
Codecov Report
@@ Coverage Diff @@
## main #5754 +/- ##
==========================================
- Coverage 80.49% 79.63% -0.87%
==========================================
Files 360 362 +2
Lines 22202 23177 +975
Branches 824 1399 +575
==========================================
+ Hits 17871 18456 +585
- Misses 4083 4347 +264
- Partials 248 374 +126
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The other instances make use of class methods included with BaseModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request was closed
Issue
Resolves #2813
Approach
Replaced event.py classes based on Pydantic.BaseModel with @dateclass
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.