-
Notifications
You must be signed in to change notification settings - Fork 107
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There was a bug discovered in unittest/gui/simulation/test_run_dialog.py::test_large_snapshot, where the mock tracker would yield the EndEvent, then sleep. This incorrect order caused the run_dialog to get the end event and close the dialog window while the QThread was still running time.sleep(), resulting in the "Thread: Destroyed while thread is still running" error. The test itself was also flaky, as it would assume the experiment was finished when it saw the boxes being drawn; not waiting for the done-button to show.
- Loading branch information
1 parent
72f02b0
commit 330a610
Showing
3 changed files
with
10 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters