Fix/datagrid bugs #1472
Merged
Fix/datagrid bugs #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: integers are treated as strings - fix: copy from excel adds line to data object - fix: add rows button still enabled tough adjustableRows is set to false - fix: export functionality doesn't work when including row labels - fix: missing labels for some use-cases
awesthouse
force-pushed
the
fix/datagrid-bugs
branch
from
8ced097 to
8bddc41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
fix: integers are treated as strings
fix: copy from excel adds line to data object
fix: add rows button still enabled tough adjustableRows is set to
false
fix: export functionality doesn't work when including row labels
fix: missing labels for some use-cases
chore: add datagrid e2e tests
chore: add test case for numeric (integer) type
Refactored the way we create labels.
Removed possibility to merge custom and predefined labels as it over-complicated the functionality and the usage is pretty low/non-existent
Why is this pull request needed?
Datagrid seems to have quite a few bugs - need some refactoring/simplifying to reduce complexity
Issues related to this change
Closes #1463
Closes #1464
Closes #1465