fix: checkbox never optional

fix: remove logging
equinor · Jan 10, 2024 · 985d9de · 985d9de
1 parent 805d987
commit 985d9de
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/e2e/tests/plugin-default_recipe.spec.ts b/e2e/tests/plugin-default_recipe.spec.ts
@@ -12,7 +12,7 @@ test('Form default DMSS UI Recipe', async ({ page }) => {
   await expect(page.getByLabel('A required string')).toHaveValue(
     'This form has no dedicated UI Recipe'
   )
-  await expect(page.getByLabel('An optional checkbox (Optional)')).toBeVisible()
+  await expect(page.getByLabel('An optional checkbox')).toBeVisible()
   await expect(page.getByLabel('date')).toHaveValue('2023-10-17T13:30')
   await expect(page.getByTestId('form-submit')).toBeVisible()
 })

diff --git a/e2e/tests/plugin-form-ReadOnlyPrimitives.spec.ts b/e2e/tests/plugin-form-ReadOnlyPrimitives.spec.ts
@@ -20,9 +20,7 @@ test('Read only primitives', async ({ page }) => {
 
   await expect(page.getByLabel('Integer only (Optional)')).not.toBeEditable()
 
-  await expect(
-    page.getByLabel('An optional checkbox (Optional)')
-  ).not.toBeEditable()
+  await expect(page.getByLabel('An optional checkbox')).not.toBeEditable()
 
   await expect(
     page.getByLabel('A required checbox (e.g. for confirmation purposes)')

diff --git a/e2e/tests/plugin-form-Simple.spec.ts b/e2e/tests/plugin-form-Simple.spec.ts
@@ -33,7 +33,7 @@ test('Simple form', async ({ page }) => {
   })
 
   await test.step('Check checkbox', async () => {
-    await page.getByLabel('An optional checkbox (Optional)').check()
+    await page.getByLabel('An optional checkbox').check()
     //await page.getByTestId('form-submit').click()
     // await expect(page.getByText('<Field is mandatory>')).toBeVisible() //Known bug (itemid:37251754)
     await page
@@ -57,9 +57,7 @@ test('Simple form', async ({ page }) => {
     await expect(page.getByLabel('Required string')).toHaveValue('Foo')
     await expect(page.getByLabel('Numbers only (Optional)')).toHaveValue('3.14')
     await expect(page.getByLabel('Integer only (Optional)')).toHaveValue('123')
-    await expect(
-      page.getByLabel('An optional checkbox (Optional)')
-    ).toBeChecked()
+    await expect(page.getByLabel('An optional checkbox')).toBeChecked()
     await expect(
       page.getByLabel('A required checkbox (e.g. for confirmation purposes)')
     ).toBeChecked()

diff --git a/packages/dm-core-plugins/src/form/fields/StringField.tsx b/packages/dm-core-plugins/src/form/fields/StringField.tsx
@@ -10,7 +10,6 @@ export const StringField = (props: TField) => {
   const Widget = getWidget(uiAttribute?.widget ?? 'TextWidget')
   const { config } = useRegistryContext()
   const readOnly = uiAttribute?.readOnly || config.readOnly
-  console.log(uiAttribute)
   return (
     <Controller
       name={namePath}