fix: Output width limit #167
Open
+686
−504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng headers Move width checker method to more general utils.py
MegaAnda123
approved these changes
Oct 2, 2024
| Headers.SCALE_FACTOR: "{:.10g}".format, | ||
| Headers.ROUGHNESS: "{:.10g}".format, | ||
| Headers.CONNECTION_FACTOR: "{:.10g}".format, | ||
| "CONNECTION_FACTOR": "{:.10g}".format, |
There was a problem hiding this comment.
Add header variations to Headers in constants.py and use them from there?
Maybe add a default format to the headers as well and get them from there?
There was a problem hiding this comment.
See: #168
Fix linter-warning by making mapping mutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a description of the change done
Why
The motivation for the change (if applicable)
Some reservoir simulators using our output have character limits.
Close: #166
Checklist:
Before submitting this PR, please make sure: