-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Output width limit #167
base: main
Are you sure you want to change the base?
Conversation
…ng headers Move width checker method to more general utils.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
Headers.SCALE_FACTOR: "{:.10g}".format, | ||
Headers.ROUGHNESS: "{:.10g}".format, | ||
Headers.CONNECTION_FACTOR: "{:.10g}".format, | ||
"CONNECTION_FACTOR": "{:.10g}".format, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add header variations to Headers in constants.py and use them from there?
Maybe add a default format to the headers as well and get them from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: #168
Fix linter-warning by making mapping mutable.
Description
Include a description of the change done
Why
The motivation for the change (if applicable)
Some reservoir simulators using our output have character limits.
Close: #166
Checklist:
Before submitting this PR, please make sure: