feat: Injection valve #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrsut
requested changes
Jun 19, 2024
| WSEGINJV = """ | ||
| WSEGINJV | ||
| -- Number Cv_Inj Primary_Ac Secondary_Ac Water_Rate_cutoff Pressure_drop_cutoff | ||
| 1 0.96 4.700e-04 8e-5 -150 -0.5 |
There was a problem hiding this comment.
do we need to put the rate and pressure drop as negative? it is not a so user friendly or intepretable as negative?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing injection valve in the completor.
Why
New valve is coming.
Close: #111
Checklist:
Before submitting this PR, please make sure: