Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update local lint task to only lint changed files #851

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Feb 4, 2025

Since we might periodically change linter configuration, as done in #849, we should keep the existing PR validation behavior that only lints the files that were changed in a particular PR. This will allow us to continue to avoid unnecessarily large PRs to fix linting failures if and when the linter configuration changes.

If we're keeping the current, limited PR validation behavior, we should use the same behavior for the make lint task to that developers can easily identify the minimum necessary changes locally. This updates the make lint task to only lint files that have been changed since origin/main, which should closely approximate the behavior of the PR validation workflow.

@ctreatma ctreatma marked this pull request as ready for review February 4, 2025 19:07
@ctreatma ctreatma requested review from a team as code owners February 4, 2025 19:07
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested locally as well. Thanks, @ctreatma !

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.03%. Comparing base (432b381) to head (e3e4396).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #851   +/-   ##
=======================================
  Coverage   35.03%   35.03%           
=======================================
  Files         187      187           
  Lines       24846    24846           
=======================================
  Hits         8704     8704           
  Misses      15995    15995           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreatma ctreatma merged commit 0e3cd17 into main Feb 5, 2025
7 checks passed
@ctreatma ctreatma deleted the lint-config branch February 5, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants