Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full review post-trial 02 #47

Merged
merged 9 commits into from
May 4, 2024
Merged

full review post-trial 02 #47

merged 9 commits into from
May 4, 2024

Conversation

avallecam
Copy link
Member

@avallecam avallecam commented Apr 18, 2024

This PR aims to collect edit suggestions from trial 02

Fix #50
Fix #37
Fix #52
Fix #57
Fix #53
Fix #51
Fix #54

@avallecam avallecam self-assigned this Apr 18, 2024
Copy link

github-actions bot commented Apr 18, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-middle/compare/md-outputs..md-outputs-PR-47

The following changes were observed in the rendered markdown documents:

 create-forecast.md                                 | 172 ++++++++++++---------
 data-severity-static.R                             |  17 +-
 ...-forecast-rendered-unnamed-chunk-10-1.png (new) | Bin 0 -> 10137 bytes
 ...-forecast-rendered-unnamed-chunk-12-1.png (new) | Bin 0 -> 8226 bytes
 fig/create-forecast-rendered-unnamed-chunk-4-1.png | Bin 50555 -> 50085 bytes
 ...e-forecast-rendered-unnamed-chunk-8-1.png (new) | Bin 0 -> 18492 bytes
 fig/pkgs-hexlogos-2.png (new)                      | Bin 0 -> 622072 bytes
 md5sum.txt                                         |   6 +-
 reference.md                                       |  14 +-
 severity-static.md                                 |  35 +++--
 10 files changed, 141 insertions(+), 103 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-30 11:51:00 +0000

@avallecam avallecam changed the base branch from empty to main April 29, 2024 23:00
@avallecam
Copy link
Member Author

@Degoot-AM can we have your brief review of the edits post-trial 02

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@Degoot-AM Degoot-AM self-requested a review April 30, 2024 11:57
Copy link
Contributor

@Degoot-AM Degoot-AM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @avallecam, I enjoyed reading two episodes: forecasting and severity measurement. I added a few changes to improve the readability.

@avallecam avallecam merged commit 47373ab into main May 4, 2024
4 checks passed
@avallecam avallecam deleted the post/trial-review branch May 4, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment