-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add read delays episode #5
Conversation
…utorials-early into add-read-delays
Thank you for your review @joshwlambert! I managed to go through all your specific edit suggestions. I'll re-request your review for your assessment. Here are replies to your questions.
added in epiverse-trace/tutorials#12 to solve after this PR
sadly this is not possibly in the workbench (using bib files and @tags). I still do not know why, but I'll look forward to it. I'm already subscribed to some issues on it.
I'll do that! I'll homogenize the code with quantify-transmission episode first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avallecam thanks for the changes. Everything looks good. I've unresolved one comment that I believe needs to be double checked. I haven't re-read through all the material, I just looked at the commits that resolve the comments. Feel free to request another review on a future PR if you'd like me to take another thorough look through all the material.
If we manage to render this locally, these two issues can be closed: epiverse-trace/tutorials#39 and epiverse-trace/tutorials#115
I'm having no issues rendering this branch (add-read-delays
) locally on macOS, if this helps to close these issues.
REMINDER: this is a Partial review. Before merging, redirect this to
main
This PR covers the pending review step in epiverse-trace/tutorials#104 (comment)
I'll appreciate your specific feedback providing a clear next step to remove, change or add content.
General questions to guide this are:
Specific questions:
Should we use partial words like "serial" instead of "serial interval" forepidist_db()
?Should we add assessments on how to input {epiparameter} outputs to {i2extras} or {R0}?#14How to review?
md-output-5
(drawback, figure captions not visible)delays-reuse.md
delays-functions.md
delays-challenges.md
If we manage to render this locally, these two issues can be closed: epiverse-trace/tutorials#39 and epiverse-trace/tutorials#115