-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read describe cases #39
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-early/compare/md-outputs..md-outputs-PR-39 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-04-29 19:51:25 +0000 |
@Degoot-AM thank you for requesting a review, I'll be able to do this next week on Friday. Hope this works for you. |
given that all checks have passed, the workbench workflows created a preview branch with the number of the PR: |
Yes, just recall that. Actually, we fixed this in c9954bc to avoid warnings. Try keeping this warning in the local version, and pushing this to GitHub. It should pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice arrangement of episodes covering a good diversity of packages within this task. My general suggestions go to add spaces within code chunks and brief comments in each action.
The md-output
shows and error
, so we need to solve this before merging this branch. I suggest to prioritize comments and create issues from other that may not be so relevant or may require more time. I think it would be possible to merge this PR at the end of this week.
Then, we may need to find how to rearrange the episodes later given that the describe-cases
episode already uses epiparameter.
Co-authored-by: Andree Valle Campos <[email protected]>
Co-authored-by: Andree Valle Campos <[email protected]>
Co-authored-by: Andree Valle Campos <[email protected]>
Co-authored-by: Andree Valle Campos <[email protected]>
Co-authored-by: Andree Valle Campos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first submit for early tutorials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready to merge 🚀
I fixed the errors visible in the md-outputs-PR
in this commit 1f956a0 I followed the template in this previous reading step
tutorials-early/episodes/delays-functions.Rmd
Lines 559 to 570 in fabe4f0
```{r,eval=TRUE,echo=FALSE,message=FALSE} | |
# read data from the tutorial repository R project | |
ebola_confirmed <- | |
read_csv(file.path("data", "ebola_cases.csv")) | |
``` | |
```{r,eval=FALSE,echo=TRUE} | |
# read data | |
# e.g.: if path to file is data/raw-data/ebola_cases.csv then: | |
ebola_confirmed <- | |
read_csv(here::here("data", "raw-data", "ebola_cases.csv")) | |
We should not use here::here() to read data in the workbench, instead we use file.path()
, but we can suggest the reader to use it.
A way to verify this is by running the chunks locally, getting outputs like these
This PR aims at addressing existing conflicts with origin before get more complicated. This issues specifically arise from
including the development version of
{cleanepi}
package. It also adds the following episodes:This PR addresses issues #21 and #22.