Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 108 #131

Merged
merged 14 commits into from
Oct 1, 2024
Merged

Fix issue 108 #131

merged 14 commits into from
Oct 1, 2024

Conversation

Degoot-AM
Copy link
Contributor

This PR resolves the issues outlined in #108 by separating the data cleaning and validation processes as follows:

  1. Added a new data file: cleaned_data.csv, which contains the cleaned dataset.

  2. Created a new episode: validate.Rmd, specifically dedicated to data validation tasks.

  3. Reorganized content: Moved relevant sections related to data validation from the clean-data.Rmd episode into the newly created validate.Rmd.

Copy link

github-actions bot commented Sep 23, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-early/compare/md-outputs..md-outputs-PR-131

The following changes were observed in the rendered markdown documents:

 clean-data.md               |   604 +-
 config.yaml (gone)          |    83 -
 data/cleaned_data.csv (new) | 15001 ++++++++++++++++++++++++++++++++++++++++++
 md5sum.txt                  |    27 +-
 renv.lock (gone)            |  2719 --------
 validate.md (new)           |   477 ++
 6 files changed, 15712 insertions(+), 3199 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-01 01:19:24 +0000

github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Degoot-AM for working on this! I build some commits on top of yours. I'll do the merge 🚀

@avallecam avallecam merged commit 8c78a1e into main Oct 1, 2024
6 checks passed
@avallecam avallecam deleted the fix_issue_108 branch October 1, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants