Decrease R mininum version to 4.0.0 #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlambert
added
CI
pkg infrastructure
joshwlambert
changed the title
|
This PR fails the R-CMD-check CI for both R v3.6.0 and v4.0.0. Due to {epireview} depending on {gdtools} which requires R 4.0 and then {distributional} which released v0.5.0 using the base pipe ( Therefore, I will close this PR without merging, and retain the minimum R version of 4.1.0 for {epiparameter} and add a explicit R-CMD-check CI for R 4.1 on a separate PR. The alternative would be to wait to for a new {distributional} release to enable the minimum R version to be 4.0, but this seems like a marginal gain and would be a blocker to releasing {epiparameter}. |
|
Closing, superseded by #405. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the minimum R version required by {epiparameter} to 4.0.0, after it was incremented to 4.1.0 in PR #384 (due to mitchelloharawild/distributional#128).
This PR also adds a R-CMD-check CI run for R 4.0 to check that the R package passes the check on the version stated in the
DESCRIPTION.This PR initially checked to see if the minimum R version could be reverted to 3.6.0 as it was before #384, however, due to {epireview} depending on {flextable} which in turn depends on {gdtools} which requires R 4.0, then this is required for the R-CMD-check workflow to install {epireview}.
Usage of the base pipe (
|>) has been replaced in a vignette by the pipe from {magrittr} (%>%), with {magrittr} added as a suggested dependency.The note in the
design_principles.Rmdvignette on breaking the Epiverse R version policy has been removed as this will not longer be the case.