Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internal parameter cleaning #331

Merged
merged 18 commits into from
Jun 10, 2024
Merged

Refactor internal parameter cleaning #331

merged 18 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. update clean_epidist_params to use switch and do.call instead of S3 d… 

    …ispatch
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d4a3e22 View commit details
    Browse the repository at this point in the history

  2. updated clean_epidist_params functions documentation

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e27afae View commit details
    Browse the repository at this point in the history

  3. update clean_epidist_params calls in accessors and new_epidist

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    981a9af View commit details
    Browse the repository at this point in the history

  4. updated clean_epidist_params tests

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a715fbe View commit details
    Browse the repository at this point in the history

  5. add bullet point to design principles vignette on S3 dispatch vs swit… 

    …ch and do.call
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5ad33df View commit details
    Browse the repository at this point in the history

  6. add bullet point on dot prefix for internal functions to design princ… 

    …iples vignette
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1e2a570 View commit details
    Browse the repository at this point in the history

  7. add dot prefix to clean_epidist_params and clean_epidist_params_* fun… 

    …ctions
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c1a4e42 View commit details
    Browse the repository at this point in the history

  8. update .clean_epidist_params documentation to group all .clean_epidis… 

    …t_params_* functions
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ca70703 View commit details
    Browse the repository at this point in the history

  9. add probability distribution name for more informative error in .clea… 

    …n_epidist_params
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    794d4fd View commit details
    Browse the repository at this point in the history

  10. add "lambda" as possible parameterisation for poisson distribution in… 

    … is_epidist_params
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d7c5dd4 View commit details
    Browse the repository at this point in the history

  11. fixed error messages from .clean_epidist_params in unit tests

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d46abae View commit details
    Browse the repository at this point in the history

  12. enforce stricter parameter matching in is_epidist_params

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    cffbe5e View commit details
    Browse the repository at this point in the history

  13. remove .clean_epidist_params_weibull as it only has one parameterisation

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0c0dac7 View commit details
    Browse the repository at this point in the history

  14. simplify .clean_epidist_params_* functions logic with after stricter … 

    …parameter matching
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4213a25 View commit details
    Browse the repository at this point in the history

  15. fix is_epidist_params and .clean_epidist_params to work with truncate… 

    …d dists with strict matching
    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    221c7f4 View commit details
    Browse the repository at this point in the history

  16. only append mean to prob_dist_params if in set of dists in new_epidist

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8542f82 View commit details
    Browse the repository at this point in the history

  17. slightly increase tolerance in expect_equal for .read.epidist_db test

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    48167ac View commit details
    Browse the repository at this point in the history

  18. updated .clean_epidist_params documentation

    @joshwlambert
    joshwlambert committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5387f70 View commit details
    Browse the repository at this point in the history