Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finalsize_comparison.Rmd #151

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Update finalsize_comparison.Rmd #151

merged 2 commits into from
Jan 19, 2024

Conversation

adamkucharski
Copy link
Member

The vignette comparing finalsize and epidemics is currently framed on numerical comparison, which adds limited value for users (because two equivalent models should produce very similar numerical outputs). Instead, have tweaked to frame around input complexity, as users of epidemics may define a complex model but not have all the parameters defined, so this vignette is now framed around how they can use finalsize in meantime in an integrated way (and the advantages/disadvantages of taking these approaches).
epiverse-trace/finalsize#190

  • Please check if the PR fulfills these requirements
  • [ X] I have read the CONTRIBUTING guidelines
  • A new item has been added to NEWS.md - Not included as this PR is only small copy changes in documentation rather than any functionality/code changes.
  • [ X] Tests for the changes have been added (for bug fixes / features)
  • [ X] Docs have been added / updated (for bug fixes / features)

Copy link
Collaborator

@pratikunterwegs pratikunterwegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamkucharski, happy to go with your additions.

@pratikunterwegs pratikunterwegs merged commit 168732a into main Jan 19, 2024
8 checks passed
@pratikunterwegs pratikunterwegs deleted the edit-vignette branch January 19, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants