Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UI agnostic of epinio's namespace and other improvements #364

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

richard-cox
Copy link
Member

Summary

Fixes #322

Occurred changes and/or fixed issues

  • Epinio can be installed to namespaces other than epinio
  • This PR remove's the hardcoding to epinio and discovers it instead by ns of the epinio-server pod
  • Also
    • Make home page link to cluster explorer's home page into a true anchor
    • Add a link to take user from an epinio application to cluster explorers deployment detail page

Areas or cases that should be tested

  • Embedded world - Discovery of epinio instances
  • Embedded world - Metrics link on home page
  • Embedded world - Link from App to Explorer Deployment Detail page

@richard-cox richard-cox added this to the v1.12.0 milestone Nov 20, 2023
@richard-cox richard-cox self-assigned this Nov 20, 2023
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a small fix to exclude local cluster from epinio instances table

@torchiaf torchiaf self-requested a review November 22, 2023 16:53
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local cluster is listed as epinio cluster but it isn't:

image

In a first round, I assumed local cluster had to be removed from the list, but given PR 366 , I think there is a bug in ingresses/namespaces calculation in discover() function.

Edit:

The instances table works fine in a clean environment! I'll approve it.

Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit af846fe into epinio:main Nov 27, 2023
10 checks passed
@richard-cox richard-cox deleted the fix-make-ns-agnostic branch November 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Ensure embedded UI works when Epinio is installed in namespaces other than epinio
2 participants