-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UI agnostic of epinio's namespace and other improvements #364
Conversation
- means url is provided to anchor (shows link, can right click open new tab, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a small fix to exclude local cluster from epinio instances table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local
cluster is listed as epinio cluster but it isn't:
In a first round, I assumed local cluster had to be removed from the list, but given PR 366 , I think there is a bug in ingresses/namespaces calculation in discover()
function.
Edit:
The instances table works fine in a clean environment! I'll approve it.
19170d4
to
e114983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Fixes #322
Occurred changes and/or fixed issues
epinio
epinio
and discovers it instead by ns of the epinio-server podAreas or cases that should be tested