[ui] Supply service chart values when creating a service #300

torchiaf · 2023-08-07T17:23:52Z

Summary

Fixes #338
Fixes #296

Technical Notes

How to create service chart settings for a Service Catalog: https://docs.epinio.io/howtos/create_custom_service#user-settable-configuration-values
Epinio 1.9.0 supports only basic key-value string maps.
Edit service chart values is not supported at the moment. The chart fields are disabled in edit mode.

Screenshots

View:

Create:

Edit:

Signed-off-by: Francesco Torchia <[email protected]>

richard-cox

in the shared epinio i've updated the mysql-dev service to include

    "ingress.enabled":
      type: "bool"
    "ingress.hostname":
      type: "string"

clicking the ingress.enabled checkbox doesn't check the box until text is entered in the ingress.hostname field
when saving this the service failed to be created (could be that it expects the settings to correlate with helm variables?)
- Edit - this did eventually deploy. we might not be waiting long enough for the deployed state
the detail view (read only edit view) shows quotes for the text

dashboard/pkg/epinio/edit/services.vue

andreas-kupries · 2023-08-08T13:04:15Z

in the shared epinio i've updated the mysql-dev service to include

    "ingress.enabled":
      type: "bool"
    "ingress.hostname":
      type: "string"

* clicking the ingress.enabled checkbox doesn't check the box until text is entered in the `ingress.hostname` field

* when saving this the service failed to be created (could be that it expects the settings to correlate with helm variables?)
  
  * Edit - this did eventually deploy. we might not be waiting long enough for the deployed state

* the detail view (read only edit view) shows quotes for the text
  
  * ![image](https://user-images.githubusercontent.com/18697775/259103587-8e5a64b9-c503-4ef0-90f9-df5e8bb84c73.png)

Note https://deploy-preview-265--epinio-docs-staging.netlify.app/next/howtos/using_custom_service_values
documenting how the various forms in a charts values.yaml, a service's settings, and the -v options correlate.

Note especially the array and map support.

torchiaf · 2023-08-10T13:03:07Z

clicking the ingress.enabled checkbox doesn't check the box until text is entered in the ingress.hostname field

I could verify this bug on Service charts, applications chart work fine. Needs investigation

when saving this the service failed to be created (could be that it expects the settings to correlate with helm variables?)

Edit - this did eventually deploy. we might not be waiting long enough for the deployed state

This is also happening testing main branch, I opened an issue for that: #298

the detail view (read only edit view) shows quotes for the text

The UI correctly sends string values without double quotes, then epinio returns back settings with quoted strings:

Request:
Response:

It seems to be a regression, needs to double check with the be team and open an issue, in case.

torchiaf · 2023-08-10T13:05:56Z

in the shared epinio i've updated the mysql-dev service to include
    "ingress.enabled":
      type: "bool"
    "ingress.hostname":
      type: "string"
* clicking the ingress.enabled checkbox doesn't check the box until text is entered in the `ingress.hostname` field

* when saving this the service failed to be created (could be that it expects the settings to correlate with helm variables?)
  
  * Edit - this did eventually deploy. we might not be waiting long enough for the deployed state

* the detail view (read only edit view) shows quotes for the text
  
  * ![image](https://user-images.githubusercontent.com/18697775/259103587-8e5a64b9-c503-4ef0-90f9-df5e8bb84c73.png)
Note https://deploy-preview-265--epinio-docs-staging.netlify.app/next/howtos/using_custom_service_values documenting how the various forms in a charts values.yaml, a service's settings, and the -v options correlate.

Note especially the array and map support.

I'm opening a new issue to support new array types: #302 .

torchiaf · 2023-08-10T13:35:06Z

Thanks @richard-cox , small issues from UI side are fixed. There are a few related pending issues :

Timeout error when creating services with bound apps: Timeout exceeded when creating & binding a new service #298
Support complex setting types: [ui] Service/Application charts values, add support for complex types #302
Quoted strings: verified by backend: [backend] String values are saved with double quotes in Chart values/settings epinio#2510
Cannot edit services: [backend] It's not possible to edit Service chart values/settings #303

Signed-off-by: Francesco Torchia <[email protected]>

richard-cox

there's some interesting things going on with the spec (added a comment to #302 (comment)). those don't block this pr though

dashboard/pkg/epinio/models/services.js

richard-cox · 2023-08-14T12:48:41Z

dashboard/pkg/epinio/edit/services.vue

    };
  },

+  mounted() {
+    if (this.mode !== 'create') {
+      this.value.details().then((details: any) => {


See comment for service model details.

This will make a http request to fetch the service that we're already viewing. If the user refreshes on the page it'll be the second request to fetch the same service.

If there are scenarios where the settings section is missing we should make the request optional given that scenario (and use epinio/find with force: true when fetching).

Replaced with store function.

There's still the issue of making an unneeded second request if the user refreshes on the view or edit service page.

Even when navigating here from the list page they will already have the resource.

How come we need to make this request, is there a scenario when information is missing?

Additional find request is done because the custom settings is provided only by /namespaces/{Namespace}/services GET request.
Request to add custom settings to the services list API: epinio/epinio#2519

@richard-cox we verified that the settings are correctly provided by services list api, and are provided by CreateEditView underneath component: epinio/epinio#2519 (comment)
Given that, I removed the extra request.

Signed-off-by: Francesco Torchia <[email protected]>

richard-cox

just one comment, then we're good

Signed-off-by: Francesco Torchia <[email protected]>

torchiaf added 5 commits August 7, 2023 19:08

Fix Catalog Service value in edit mode, #296

6d762f7

Signed-off-by: Francesco Torchia <[email protected]>

Create generic ChartValues component to manage ChartValueSettings

fa696d6

Signed-off-by: Francesco Torchia <[email protected]>

import ChartValues component into AppInfo

81b0b6c

Signed-off-by: Francesco Torchia <[email protected]>

Add ChartValues to Service form

d2e1b3c

Signed-off-by: Francesco Torchia <[email protected]>

Disable Chart Values in EDIT mode

09544ae

Signed-off-by: Francesco Torchia <[email protected]>

torchiaf requested a review from richard-cox August 7, 2023 17:23

torchiaf self-assigned this Aug 7, 2023

Reset chart values when changing service catalog

94f021a

Signed-off-by: Francesco Torchia <[email protected]>

torchiaf removed their assignment Aug 8, 2023

richard-cox requested changes Aug 8, 2023

View reviewed changes

dashboard/pkg/epinio/edit/services.vue Outdated Show resolved Hide resolved

dashboard/pkg/epinio/edit/services.vue Show resolved Hide resolved

dashboard/pkg/epinio/edit/services.vue Show resolved Hide resolved

dashboard/pkg/epinio/edit/services.vue Outdated Show resolved Hide resolved

torchiaf mentioned this pull request Aug 10, 2023

[ui] Service/Application charts values, add support for complex types #302

Open

torchiaf requested a review from richard-cox August 10, 2023 13:35

torchiaf mentioned this pull request Aug 10, 2023

[backend] String values are saved with double quotes in Chart values/settings epinio/epinio#2510

Closed

Adress small change requests

602dd7e

Signed-off-by: Francesco Torchia <[email protected]>

richard-cox requested changes Aug 14, 2023

View reviewed changes

Replace details() with epinio/find from store

7411137

Signed-off-by: Francesco Torchia <[email protected]>

torchiaf requested a review from richard-cox August 17, 2023 08:52

torchiaf self-assigned this Aug 17, 2023

richard-cox added this to the v1.10.0 milestone Aug 21, 2023

richard-cox requested changes Aug 21, 2023

View reviewed changes

Get Chart Values from sevices list response

e40e0be

Signed-off-by: Francesco Torchia <[email protected]>

torchiaf requested a review from richard-cox August 21, 2023 16:10

richard-cox approved these changes Aug 21, 2023

View reviewed changes

torchiaf merged commit 834b47e into epinio:main Aug 21, 2023
3 checks passed

richard-cox changed the title ~~[ui] Add/Edit service chart values~~ [ui] Supply service chart values when creating an app Sep 4, 2023

richard-cox added the kind/enhancement New feature or request label Sep 4, 2023

richard-cox changed the title ~~[ui] Supply service chart values when creating an app~~ [ui] Supply service chart values when creating a service Sep 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ui] Supply service chart values when creating a service #300

[ui] Supply service chart values when creating a service #300

torchiaf commented Aug 7, 2023 •

edited by richard-cox

Loading

richard-cox left a comment •

edited

Loading

andreas-kupries commented Aug 8, 2023

torchiaf commented Aug 10, 2023 •

edited

Loading

torchiaf commented Aug 10, 2023 •

edited

Loading

torchiaf commented Aug 10, 2023 •

edited

Loading

richard-cox left a comment

richard-cox Aug 14, 2023

torchiaf Aug 17, 2023

richard-cox Aug 21, 2023

torchiaf Aug 21, 2023

torchiaf Aug 21, 2023 •

edited

Loading

richard-cox left a comment

[ui] Supply service chart values when creating a service #300

[ui] Supply service chart values when creating a service #300

Conversation

torchiaf commented Aug 7, 2023 • edited by richard-cox Loading

Summary

Technical Notes

Screenshots

richard-cox left a comment • edited Loading

Choose a reason for hiding this comment

andreas-kupries commented Aug 8, 2023

torchiaf commented Aug 10, 2023 • edited Loading

torchiaf commented Aug 10, 2023 • edited Loading

torchiaf commented Aug 10, 2023 • edited Loading

richard-cox left a comment

Choose a reason for hiding this comment

richard-cox Aug 14, 2023

Choose a reason for hiding this comment

torchiaf Aug 17, 2023

Choose a reason for hiding this comment

richard-cox Aug 21, 2023

Choose a reason for hiding this comment

torchiaf Aug 21, 2023

Choose a reason for hiding this comment

torchiaf Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

richard-cox left a comment

Choose a reason for hiding this comment

torchiaf commented Aug 7, 2023 •

edited by richard-cox

Loading

richard-cox left a comment •

edited

Loading

torchiaf commented Aug 10, 2023 •

edited

Loading

torchiaf commented Aug 10, 2023 •

edited

Loading

torchiaf commented Aug 10, 2023 •

edited

Loading

torchiaf Aug 21, 2023 •

edited

Loading