Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add install/uninstall buttons to clusters in the cluster list #366

Closed
wants to merge 3 commits into from
Closed

Add install/uninstall buttons to clusters in the cluster list #366

wants to merge 3 commits into from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Nov 20, 2023 •
edited
Loading

Summary

Fixes #367

Occurred changes and/or fixed issues

  • Enhance the initial experience of the ui-extension by guiding the user to install epinio on clusters that we can't find it on
    • for clusters which we've found epinio on... and they can... show uninstall action
    • for cluster with no epinio on... and they can... show install button

Technical notes summary

Areas or cases that should be tested

  • install action leads user to the cluster's epinio chart detail page
  • uninstall action leads users to cluster's helm app page with the query string "epinio"
  • when there are no epinio instances detected we show a nice intro guiding to install action

Screenshot/Video

Screenshot_20231127_100958

@richard-cox richard-cox added this to the v1.12.0 milestone Nov 20, 2023
@richard-cox richard-cox self-assigned this Nov 20, 2023
@torchiaf torchiaf mentioned this pull request Nov 22, 2023
Merged
@torchiaf
Copy link
Contributor

The functionality looks good overall, It will require another round of review after #364 is merged, rebase and code clean-up.

@richard-cox
Add install/uninstall buttons to clusters in the cluster list
9b97c06 
- we now show all clusters
- for clusters which we've found epinio on... and they can... show uninstall action
- for cluster with no epinio on... and they can... show install button
@richard-cox
Remove debugger, bump ext version
e542288
@richard-cox richard-cox force-pushed the enhancement-improve-cluster-list-table branch from 0b76beb to e542288 Compare November 27, 2023 09:53
@richard-cox richard-cox closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf Awaiting requested review from torchiaf

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

Improve landing experience when using ui extension
2 participants
@richard-cox @torchiaf