Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Add/Edit service chart values #252

Closed
2 of 3 tasks
richard-cox opened this issue Jun 19, 2023 · 9 comments
Closed
2 of 3 tasks

[ui] Add/Edit service chart values #252

richard-cox opened this issue Jun 19, 2023 · 9 comments
Assignees
Labels
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Jun 19, 2023

Tasks

  1. kind/enhancement
    torchiaf
  2. kind/enhancement
    torchiaf
  3. blocked-backend kind/enhancement
    torchiaf
@richard-cox
Copy link
Member Author

See epinio/epinio#1633 (comment)

@richard-cox
Copy link
Member Author

@torchiaf this will be complete when epinio/epinio#2522 is integrated right?

@thehejik
Copy link
Contributor

thehejik commented Aug 31, 2023

Test Report

Test

  • run kubectl edit services.application.epinio.io -n epinio mysql-dev and enter following (settings at values level):
  settings:
    auth.rootPassword:
      type: string
    global.storageClass:
      enum:
      - default
      - local-path
      - none
      type: string
    primary.persistence.enabled:
      type: bool
    primary.service.ports.mysql:
      maximum: "3307"
      minimum: "3306"
      type: integer
  • create a new service in UI by using modified mysql-dev service catalog and put reasonable values:
    pasted_image
  • Verify by CLI that the service is deployed and the values are propagated into the service:
$ epinio service show mysql-values-ui

🚢  Showing Service...

✔️  Details:
|       KEY       |                                     VALUE                                      |
|-----------------|--------------------------------------------------------------------------------|
| Name            | mysql-values-ui                                                                |
| Created         | 2023-08-31 16:30:09 +0200 CEST                                                 |
| Catalog Service | mysql-dev                                                                      |
| Version         | 8.0.31                                                                         |
| Status          | deployed                                                                       |
| Used-By         |                                                                                |
| Internal Routes | xefb34329720317139eae966f094d-mysql-headless.workspace.svc.cluster.local:3306, |
|                 | xefb34329720317139eae966f094d-mysql.workspace.svc.cluster.local:3306           |

✔️  Settings
|             KEY             |   VALUE    |
|-----------------------------|------------|
| auth.rootPassword           | linux      |
| global.storageClass         | local-path |
| primary.persistence.enabled | true       |
| primary.service.ports.mysql |       3306 |

✔️  Credentials:
|         KEY         |   VALUE    |
|---------------------|------------|
| mysql-password      | wgPo5Mja1G |
| mysql-root-password | linux      |

@richard-cox
Copy link
Member Author

Edit needs to big integrated / validated now epinio/epinio#2522 has been completed

@richard-cox
Copy link
Member Author

Thinking about it, lets make this issue an epic and create issues for Add (which we can say is complete for 1.10) and Edit (which will probably be for 1.11)

@torchiaf
Copy link
Contributor

torchiaf commented Sep 4, 2023

@torchiaf this will be complete when epinio/epinio#2522 is integrated right?

Now that 2522 is complete we can go forward with the UI.

@richard-cox
Copy link
Member Author

richard-cox commented Sep 5, 2023

I've split this out into two issues to denote the milestones each change will go in to

This epic will be complete when the above is finished and..

I've added these as a tasklist in the issue description

@richard-cox
Copy link
Member Author

As part of this issue we should ensure custom chart values are validated as per #299 (comment)

@richard-cox
Copy link
Member Author

Given create and edit are in the code base and tested independently i'm going to close this issue as done.

We still have #302, that is now targeted at 1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Status: Done
Development

No branches or pull requests

3 participants