Fix incorrect computations for unit_price_decimal for discounted prices #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulofph
reviewed
Jan 3, 2025
| * Right now we have a solution that targets specifically discounted prices, | ||
| * but this should be generalized. | ||
| */ | ||
| ...(price?.pricing_model === PricingModel.perUnit && { unit_amount_decimal: unitAmountDecimal }), |
There was a problem hiding this comment.
It doesn't look correct.
Did you understand why are we adding it only when it's per_unit?
paulofph
reviewed
Jan 3, 2025
| * but this should be generalized. | ||
| */ | ||
| ...(price?.pricing_model === PricingModel.perUnit && { unit_amount_decimal: unitAmountDecimal }), | ||
| ...(typeof itemValues.unit_amount === 'number' && |
There was a problem hiding this comment.
All these conditions should be evaluated to true. Since we are using dineroJS to compute values it only uses and outputs integers, if you are receiving here any other thing the issue should be before this step.
paulofph
approved these changes
Jan 3, 2025
…/incorrect-computations-for-unit_price_decimal-for-discounted-prices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.