Merge pull request #135 from epilot-dev/fix/resolve-undefined-cashbac…

…k-period Fix: add logic for required cashback period and amount
epilot-dev · Nov 19, 2024 · d93033e · d93033e
2 parents 58e4151 + 2925041
commit d93033e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -54,7 +54,7 @@
   "author": "epilot GmbH",
   "license": "UNLICENSED",
   "dependencies": {
-    "@epilot/pricing-client": "^3.35.15",
+    "@epilot/pricing-client": "^3.35.17",
     "@types/dinero.js": "^1.9.0",
     "dinero.js": "^1.9.1"
   },

diff --git a/src/pricing.ts b/src/pricing.ts
@@ -453,6 +453,8 @@ const recomputeDetailTotals = (
     typeof priceItemToAppend.cashback_amount !== 'undefined'
       ? toDineroFromInteger(priceItemToAppend.cashback_amount!)
       : undefined;
+
+  const cashbackPeriod = priceItemToAppend.cashback_period;
   const priceBeforeDiscountAmountTotal =
     typeof priceItemToAppend.before_discount_amount_total !== 'undefined'
       ? toDineroFromInteger(priceItemToAppend.before_discount_amount_total!)
@@ -564,13 +566,12 @@ const recomputeDetailTotals = (
   }
 
   // Cashback totals
-  if (priceCashBackAmount) {
-    const cashbackPeriod = priceItemToAppend.cashback_period;
+  if (priceCashBackAmount && cashbackPeriod !== undefined) {
     const cashbackMatchIndex = cashbacks.findIndex((cashback) => cashback.cashback_period === cashbackPeriod);
 
     if (cashbackMatchIndex !== -1) {
-      const matchingCashback = cashbacks[cashbackMatchIndex]!;
-      const cashbackAmountTotal = toDineroFromInteger(matchingCashback.amount_total!);
+      const matchingCashback = cashbacks[cashbackMatchIndex];
+      const cashbackAmountTotal = toDineroFromInteger(matchingCashback.amount_total);
       matchingCashback.amount_total = cashbackAmountTotal.add(priceCashBackAmount).getAmount();
     } else {
       cashbacks.push({