Merge pull request #149 from epilot-dev/fix/estimated-simple-prices

Fix calculation of recurrences with estimated prices for simple prices
epilot-dev · Dec 19, 2024 · 9d94489 · 9d94489
2 parents dd91f38 + ee9065e
commit 9d94489
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/pricing.test.ts b/src/pricing.test.ts
@@ -682,13 +682,16 @@ describe('getRecurrencesWithEstimatedPrices', () => {
     type: 'recurring',
     billing_period: 'monthly',
     _price: {
+      type: 'recurring',
+      billing_period: 'monthly',
       price_display_in_journeys: 'estimated_price'
     }
   }
 
   const oneTimeEstimateComponent = {
     type: 'one_time',
     _price: {
+      type: 'one_time',
       price_display_in_journeys: 'estimated_price'
     }
   }
@@ -697,13 +700,16 @@ describe('getRecurrencesWithEstimatedPrices', () => {
     type: 'recurring',
     billing_period: 'monthly',
     _price: {
+      type: 'recurring',
+      billing_period: 'monthly',
       price_display_in_journeys: 'show_price'
     }
   }
 
   const oneTimeComponent = {
     type: 'one_time',
     _price: {
+      type: 'one_time',
       price_display_in_journeys: 'show_price'
     }
   }

diff --git a/src/pricing.ts b/src/pricing.ts
@@ -1269,7 +1269,8 @@ export const getRecurrencesWithEstimatedPrices = (lineItems: PriceItems | undefi
         }
       });
     } else {
-      const recurrence = lineItem.type === 'recurring' ? lineItem.billing_period : lineItem.type;
+      const recurrence =
+        lineItem._price?.type === 'recurring' ? lineItem._price?.billing_period : lineItem._price?.type;
 
       if (recurrence !== undefined) {
         recurrences[recurrence] =