Remove discount decimal repeated computations (#155)

Co-authored-by: José Carneiro <[email protected]>
epilot-dev · Jan 2, 2025 · 5e7b4ed · 5e7b4ed
1 parent a8d4e75
commit 5e7b4ed
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 19 deletions.
diff --git a/src/pricing.ts b/src/pricing.ts
@@ -829,16 +829,10 @@ export const computePriceItem = (
       before_discount_unit_amount: itemValues.before_discount_unit_amount,
     }),
     ...(Number.isInteger(itemValues.unit_discount_amount) && { unit_discount_amount: itemValues.unit_discount_amount }),
-    ...(itemValues.unit_discount_amount_decimal && {
-      unit_discount_amount_decimal: itemValues.unit_discount_amount_decimal,
-    }),
     ...(Number.isInteger(itemValues.unit_amount_net) && { unit_amount_net: itemValues.unit_amount_net }),
     ...(Number.isInteger(itemValues.unit_discount_amount_net) && {
       unit_discount_amount_net: itemValues.unit_discount_amount_net,
     }),
-    ...(itemValues.unit_discount_amount_net_decimal && {
-      unit_discount_amount_net_decimal: itemValues.unit_discount_amount_net_decimal,
-    }),
     ...(Number.isInteger(itemValues.unit_amount_gross) && { unit_amount_gross: itemValues.unit_amount_gross }),
     ...(price?.pricing_model === PricingModel.perUnit &&
       unitAmountDecimal && { unit_amount_decimal: unitAmountDecimal }),
@@ -860,18 +854,10 @@ export const computePriceItem = (
       before_discount_amount_total: itemValues.before_discount_amount_total,
     }),
     amount_tax: itemValues.amount_tax,
-    ...(Number.isInteger(itemValues.tax_discount_amount) && {
-      tax_discount_amount: itemValues.tax_discount_amount,
-    }),
-    ...(itemValues.tax_discount_amount_decimal && {
-      tax_discount_amount_decimal: itemValues.tax_discount_amount_decimal,
-    }),
+    ...(Number.isInteger(itemValues.tax_discount_amount) && { tax_discount_amount: itemValues.tax_discount_amount }),
     ...(Number.isInteger(itemValues.before_discount_tax_amount) && {
       before_discount_tax_amount: itemValues.before_discount_tax_amount,
     }),
-    ...(itemValues.before_discount_tax_amount_decimal && {
-      before_discount_tax_amount_decimal: itemValues.before_discount_tax_amount_decimal,
-    }),
     ...(itemValues.tiers_details && {
       tiers_details: itemValues.tiers_details.map((tier) => ({
         quantity: tier.quantity,

diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -243,14 +243,10 @@ export const applyDiscounts = (
     amount_total: afterDiscountUnitAmountGross.multiply(unitAmountMultiplier).getAmount(),
     amount_tax: afterDiscountTaxAmount.getAmount(),
     unit_discount_amount: unitDiscountAmount.getAmount(),
-    unit_discount_amount_decimal: unitDiscountAmount.toUnit().toString(),
     before_discount_unit_amount: isTaxInclusive ? unitAmountGross.getAmount() : unitAmountNet.getAmount(),
     unit_discount_amount_net: unitDiscountAmountNet.getAmount(),
-    unit_discount_amount_net_decimal: unitDiscountAmountNet.toUnit().toString(),
     tax_discount_amount: taxDiscountAmount.getAmount(),
-    tax_discount_amount_decimal: taxDiscountAmount.toUnit().toString(),
     before_discount_tax_amount: beforeDiscountTaxAmount.multiply(unitAmountMultiplier).getAmount(),
-    before_discount_tax_amount_decimal: beforeDiscountTaxAmount.toUnit().toString(),
     discount_amount: unitDiscountAmount.multiply(unitAmountMultiplier).getAmount(),
     discount_percentage: discountPercentage,
     before_discount_amount_total: unitAmountGross.multiply(unitAmountMultiplier).getAmount(),