Merge pull request #56 from epilot-dev/feat/normalize-function-suppor…

…ts-strings Feat: Normalize time frequemcy function supports strings
epilot-dev · Feb 21, 2024 · 4b87196 · 4b87196
2 parents 5038118 + 822992d
commit 4b87196
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/normalizers/index.test.ts b/src/normalizers/index.test.ts
@@ -62,6 +62,11 @@ describe('normalizeTimeFrequency', () => {
     ${24000}    | ${'yearly'}         | ${'Monthly'}        | ${2000}
     ${24000}    | ${'yearly'}         | ${undefined}        | ${24000}
     ${24000}    | ${undefined}        | ${'monthly'}        | ${24000}
+    ${'2400.5'} | ${'monthly'}        | ${'weekly'}         | ${600.125}
+    ${'1000'}   | ${'monthly'}        | ${'yearly'}         | ${12000}
+    ${'1000.50'}| ${'monthly'}        | ${'yearly'}         | ${12006}
+    ${'12006'}  | ${'yearly'}        | ${'monthly'}         | ${1000.50}
+    ${'159.345'}| ${'yearly'}        | ${'monthly'}         | ${13.2788}
   `(
     `should normalize $timeValue/$timeValueFrequency properly to time frequency $targetTimeFrequency`,
     ({ timeValue, timeValueFrequency, targetTimeFrequency, expectedNormalizedValue }) => {

diff --git a/src/types/index.d.ts b/src/types/index.d.ts
@@ -27,13 +27,13 @@ export type TimeFrequency = Exclude<BillingPeriod, 'one_time'>;
 export type PriceTier = Components.Schemas.PriceTier;
 export type PriceTierDisplayMode = Components.Schemas.PriceTierDisplayMode;
 export type NormalizeTimeFrequency = (
-  timeValue: number,
+  timeValue: number | string,
   timeValueFrequency: TimeFrequency,
   targetTimeFrequency: TimeFrequency,
   precision?: number,
 ) => number;
 export type NormalizeTimeFrequencyToDinero = (
-  timeValue: number,
+  timeValue: number | string,
   timeValueFrequency: TimeFrequency,
   targetTimeFrequency: TimeFrequency,
   precision?: number,