fix(instructions): react-hooks 02.01 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exercise `react-hooks/exercises/02.side-effects/01.problem.effects/index.tsx` The current instructions don't make sense... this patch clears things up.
|
Oops, it's supposed to be broken :/ |
|
We can still clear things up a bit by explaining that it's supposed to be broken inline if you think that would provide clarity |
> in the useEffect callback, subscribe to window's popstate event If a dev knows how to use `useEffect()` this will look like a bug... because it is. Let's explain that this bug is supposed to be here at this point.
kentcdodds
reviewed
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise
react-hooks/exercises/02.side-effects/01.problem.effects/index.tsxThe current instructions don't make sense... this patch clears things up.