Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example RELEASE.local files are incorrect #56

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

thomasms
Copy link
Contributor

@thomasms thomasms commented Mar 22, 2021

Parenthesis needed instead of curly braces. This hopefully corrects the issue.

I was having an issue when trying to use this example in combination with PVXS also (see here for details).

An open question on this - why are the other variables needed (below)?
It seems to build fine for me without them. Don't we just need EPICS_BASE?

PVDATABASE=$(EPICS7_DIR)/modules/database
PVACLIENT=$(EPICS7_DIR)/modules/pvaClient
PVA2PVA=$(EPICS7_DIR)/modules/pva2pva
PVACCESS=$(EPICS7_DIR)/modules/pvAccess
NORMATIVETYPES=$(EPICS7_DIR)/modules/normativeTypes
PVDATA=$(EPICS7_DIR)/modules/pvData
TEMPLATE_TOP=$(EPICS_BASE)/templates/makeBaseApp/top

… of curly braces. This hopefully corrects the issue.
@mrkraimer
Copy link
Contributor

The following question was asked.

An open question on this - why are the other variables needed (below)?
It seems to build fine for me without them. Don't we just need EPICS_BASE?

It depends on where you a building.
It in an EPICS 7 release then no.
But if building elsewhere, for example against master branches from github then yes.

@mrkraimer mrkraimer merged commit 37f883b into epics-rip:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants