Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Include action to release deb and rpm dkms packages #134

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

gabrielfedel
Copy link
Contributor

@gabrielfedel gabrielfedel commented Mar 1, 2024

This PR includes:

  • Small change to make the deb package compatible with old debian version
  • Changes on rpm spec file to allow it be built correctly on github actions
  • Include actions to release the deb and rpm packages for dkms kernel module

Some points about the release of the packages:

  • They should be attached to a tag . I have set the deb tag as kmod-d (for example kmod-3-d0), and the rpm tag as kmod-r (for example kmod-3-r1)
  • All the release also will have the all the source code

These 2 points are a bit annoying, but I think to avoid them it will require a bit of work to implement an workflow (right now we are using one that already exists).

As an example 2 releases, one for deb and one for rpm:

https://github.com/gabrielfedel/mrfioc2/releases/tag/kmod-3-r1
https://github.com/gabrielfedel/mrfioc2/releases/tag/kmod-3-d0

@gabrielfedel
Copy link
Contributor Author

Couldn't figure out the issue with the test : https://github.com/epics-modules/mrfioc2/actions/runs/8108440408/job/22161659997?pr=134
Doesn't seems related to the changed I made.

@jerzyjamroz
Copy link
Contributor

Couldn't figure out the issue with the test : https://github.com/epics-modules/mrfioc2/actions/runs/8108440408/job/22161659997?pr=134 Doesn't seems related to the changed I made.

It seems that Ubuntu latest runs kernel 6 now (but it was not the case in the past), so it does not work.

@gabrielfedel gabrielfedel changed the title Include action to release deb and rpm dkms packages draft: Include action to release deb and rpm dkms packages Mar 1, 2024
@gabrielfedel
Copy link
Contributor Author

I set it as draft for now as I'm waiting them being built on my personal repo to check the result, but the idea should be more or less correct.

@jerzyjamroz jerzyjamroz marked this pull request as draft March 1, 2024 15:01
@gabrielfedel gabrielfedel force-pushed the release-dkms-deb branch 2 times, most recently from d9c431b to 0c52afd Compare March 1, 2024 15:31
Remove no needed tools, and set arch as noarch, considering the dkms
builds the kernel module on the host where the package is to be
installed.
Commits tagged with kmod-*d* will release deb packages
Commits tagged with kmod-*r* will release rpm packages
@gabrielfedel gabrielfedel marked this pull request as ready for review March 1, 2024 15:50
@gabrielfedel
Copy link
Contributor Author

And now is ready for review!

@gabrielfedel gabrielfedel changed the title draft: Include action to release deb and rpm dkms packages Include action to release deb and rpm dkms packages Mar 1, 2024
Copy link
Contributor

@jerzyjamroz jerzyjamroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@jerzyjamroz jerzyjamroz changed the title Include action to release deb and rpm dkms packages build: Include action to release deb and rpm dkms packages Mar 4, 2024
@jerzyjamroz jerzyjamroz added the ci label Mar 4, 2024
@gabrielfedel gabrielfedel merged commit 80443c9 into master Mar 4, 2024
26 of 28 checks passed
@gabrielfedel gabrielfedel deleted the release-dkms-deb branch March 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants