-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
64 changed files
with
3,813 additions
and
4,095 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,23 @@ | ||
# Contribute to the project | ||
# Contributing to the project | ||
|
||
Contributions and issues are most welcome! All issues and pull requests are | ||
handled through [GitHub](https://github.com/epics-containers/epics-containers.github.io/issues). Also, please check for any existing issues before | ||
handled through [GitHub]. Also, please check for any existing issues before | ||
filing a new one. If you have a great idea but it involves big changes, please | ||
file a ticket before making a pull request! We want to make sure you don't spend | ||
your time coding something that might not fit the scope of the project. | ||
|
||
## Issue or Discussion? | ||
|
||
Github also offers [discussions](https://github.com/epics-containers/epics-containers.github.io/discussions) as a place to ask questions and share ideas. If | ||
Github also offers [discussions] as a place to ask questions and share ideas. If | ||
your issue is open ended and it is not obvious when it can be "closed", please | ||
raise it as a discussion instead. | ||
|
||
## Code Coverage | ||
## Developer guide | ||
|
||
While 100% code coverage does not make a library bug-free, it significantly | ||
reduces the number of easily caught bugs! Please make sure coverage remains the | ||
same or is improved by a pull request! | ||
The [Developer Guide] contains information on setting up a development | ||
environment, building docs and what standards the documentation | ||
should follow. | ||
|
||
## Developer Information | ||
|
||
It is recommended that developers use a [vscode devcontainer](https://code.visualstudio.com/docs/devcontainers/containers). This repository contains configuration to set up a containerized development environment that suits its own needs. | ||
|
||
This project was created using the [Diamond Light Source Copier Template](https://github.com/DiamondLightSource/python-copier-template) for Python projects. | ||
|
||
For more information on common tasks like setting up a developer environment, running the tests, and setting a pre-commit hook, see the template's [How-to guides](https://diamondlightsource.github.io/python-copier-template/1.3.0/how-to.html). | ||
[developer guide]: https://epics-containers.github.io/main/developer/how-to/contribute.html | ||
[discussions]: https://github.com/epics-containers/epics-containers.github.io/discussions | ||
[github]: https://github.com/epics-containers/epics-containers.github.io/issues |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
docs/explanations/decisions/0003-use-substitution-files.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# 3. Use of substitution files to generate EPICS Databases | ||
|
||
Date: 2023-11-30 | ||
|
||
## Status | ||
|
||
Accepted | ||
|
||
## Context | ||
|
||
There are two proposals for how EPICS Databases should be generated: | ||
|
||
1. At IOC startup `ibek` should generate a substitution file that describes the | ||
required Databases. | ||
|
||
The IOC instance yaml combined with the definitions from support module yaml | ||
controls what the generated substitution file will look like. | ||
|
||
`ibek` will then execute `msi` to generate the Databases from the | ||
substitution file. | ||
|
||
2. The dbLoadRecord calls in the startup script will pass all macro substitutions | ||
in-line. Removing the need for a substitution file. | ||
|
||
## Decision | ||
|
||
Proposal 1 is accepted. | ||
|
||
Some template files such as those in the `pmac` support module use the | ||
following pattern: | ||
|
||
``` | ||
substitute "P=$(PMAC):, M=CS$(CS):M1, ADDR=1, DESC=CS Motor A" | ||
include "pmacDirectMotor.template" | ||
``` | ||
|
||
This pattern is supported by msi but not by the EPICS dbLoadRecord command which | ||
does not recognise the `substitute` command. | ||
|
||
## Consequences | ||
|
||
An extra file `ioc.subst` is seen in the runtime directory. In reality this | ||
is easier to read than a full Database file. So can be useful for debugging. | ||
|
||
Finally those developers who are unable to use `ibek yaml` for some reason can | ||
supply their own substitution file and ibek will expand it at runtime. This is | ||
much more compact that supplying a full Database file and important due to the | ||
1MB limit on K8S ConfigMaps. |
55 changes: 0 additions & 55 deletions
55
docs/explanations/decisions/0003-use-substitution-files.rst
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.