Change enable to act on root app

[marcelldls]

Change patch of enable to be on the root app. This allows ec to work with ec-helm-charts 4.0.0+b1 which aims to have enabled recorded in the git repo.
Question:

• Should this be ec stop <service> --temp? (with the git backend pushing changes to enabled being a default)
• Should we allow this at all - Because the patch sits on top of what is in the repo so we need to revert if you want to track the repo again. It has some benefits though for not relying on "the internet" and speed (directly communicate with argocd rather than git + sync argocd) + reducing number of commits added to the deployment repo

[marcelldls]

We can identify patches to params exposed to the root app using the roots app values.yaml by comparing the source manifests argocd app manifests <ns>/<rootApp> and the live state argocd app get <ns>/<rootApp> -o yaml

[gilesknap]

I'm getting the feeling that the concept of temporary vs permanent stop is over complicated.

I think that if we support ec making changes to the repo we should probably drop overrides to avoid confusion.

[codecov]

Codecov Report

Attention: Patch coverage is 90.16393% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (e4fef83) to head (d24a0e8).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/edge_containers_cli/cli.py	40.00%	6 Missing ⚠️
src/edge_containers_cli/utils.py	90.90%	3 Missing ⚠️
src/edge_containers_cli/git.py	89.47%	2 Missing ⚠️
src/edge_containers_cli/backend.py	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   80.46%   81.04%   +0.57%     
==========================================
  Files          15       15              
  Lines         809      897      +88     
==========================================
+ Hits          651      727      +76     
- Misses        158      170      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marcelldls]

@gilesknap Are you willing to try demo this? I have tried it against an auto-synced and non auto-synced app-of-apps

[gilesknap]

Sure. Let's discuss tomorrow

[marcelldls]

@gilesknap Working against https://github.com/epics-containers/p47-deployment with the discussed helm chart changes captured in epics-containers/ec-helm-charts#33 under a beta release

[marcelldls]

@gilesknap Ready - Please review against p47 and ec-helm-charts

[gilesknap]

I just want to record here that we have discussed the --temp feature and:

• it is good that the default is to update the repo as this keeps a record of beamline state
• but we do need --temp for when the git server is offline
• reporting that you can try --temp when trying to update the repo makes this temp feature discoverable
• we do need to work out what to do about authN though
  • maybe not give scientists write access to the repo - particularly because that involves fiddly config
  • using a web version of ec could mitigate this
  • but then perhaps we still need a way to supply --temp from the web UI for when the git server is offline?

[gilesknap]

I tried this and it looks all good.

And I like the comments in apps.yaml (I might add a linefeed before the first line of the ec_services comment?)

Lets merge and release!