Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for Chart.yaml instead of optional values.yaml #117

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

gilesknap
Copy link
Member

Not all services require a values.yaml and the error still mentioned IOCs.

Copy link
Collaborator

@marcelldls marcelldls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I believe the test data needs a Chart.yaml

@gilesknap
Copy link
Member Author

yeah that was a hasty fix :-)

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.80%. Comparing base (08ecdb2) to head (01a0e31).

Files Patch % Lines
src/edge_containers_cli/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files          14       14           
  Lines         788      788           
=======================================
  Hits          684      684           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gilesknap gilesknap merged commit 88b0b0c into main Mar 26, 2024
18 of 19 checks passed
@gilesknap gilesknap deleted the instance-path branch March 26, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants