Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make teku happy again (add missing genesis presets) #19

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Aug 11, 2023

It looks like newer versions of teku are enforcing some properties within the genesis config.
These properties were previously extended from the mainnet preset, so they normally don't need to be redefined within the genesis config itself.

However, newer teku complains about them when missing:

2023-08-11 00:42:40.421 INFO  - Ignoring unknown items in network configuration: EIP4844_FORK_EPOCH,EIP4844_FORK_VERSION
2023-08-11 00:42:40.427 FATAL - Missing value for spec constant 'GOSSIP_MAX_SIZE'
tech.pegasys.teku.infrastructure.exceptions.InvalidConfigurationException: Missing value for spec constant 'GOSSIP_MAX_SIZE'
at tech.pegasys.teku.cli.BeaconNodeCommand.tekuConfiguration(BeaconNodeCommand.java:416) [teku-23.6.1.jar:23.6.1]
at tech.pegasys.teku.cli.BeaconNodeCommand.call(BeaconNodeCommand.java:340) [teku-23.6.1.jar:23.6.1]
at tech.pegasys.teku.cli.BeaconNodeCommand.call(BeaconNodeCommand.java:79) [teku-23.6.1.jar:23.6.1]
at picocli.CommandLine.executeUserObject(CommandLine.java:2041) [picocli-4.7.4.jar:4.7.4]
at picocli.CommandLine.access$1500(CommandLine.java:148) [picocli-4.7.4.jar:4.7.4]
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461) [picocli-4.7.4.jar:4.7.4]
at picocli.CommandLine$RunLast.handle(CommandLine.java:2453) [picocli-4.7.4.jar:4.7.4]
at picocli.CommandLine$RunLast.handle(CommandLine.java:2415) [picocli-4.7.4.jar:4.7.4]
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273) [picocli-4.7.4.jar:4.7.4]
at picocli.CommandLine$RunLast.execute(CommandLine.java:2417) [picocli-4.7.4.jar:4.7.4]
at picocli.CommandLine.execute(CommandLine.java:2170) [picocli-4.7.4.jar:4.7.4]
at tech.pegasys.teku.cli.BeaconNodeCommand.parse(BeaconNodeCommand.java:273) [teku-23.6.1.jar:23.6.1]
at tech.pegasys.teku.Teku.start(Teku.java:63) [teku-23.6.1.jar:23.6.1]
at tech.pegasys.teku.Teku.startFromCLIArgs(Teku.java:86) [teku-23.6.1.jar:23.6.1]
at tech.pegasys.teku.Teku.main(Teku.java:40) [teku-23.6.1.jar:23.6.1]
Caused by: java.lang.IllegalArgumentException: Missing value for spec constant 'GOSSIP_MAX_SIZE'
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:218) ~[guava-32.0.1-jre.jar:?]
at tech.pegasys.teku.spec.config.builder.SpecBuilderUtil.validateNotNull(SpecBuilderUtil.java:63) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.config.builder.SpecBuilderUtil.validateConstant(SpecBuilderUtil.java:58) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.config.builder.SpecConfigBuilder.validate(SpecConfigBuilder.java:258) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.config.builder.SpecConfigBuilder.build(SpecConfigBuilder.java:133) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.config.SpecConfigReader.build(SpecConfigReader.java:113) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.config.SpecConfigReader.build(SpecConfigReader.java:118) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.config.SpecConfigLoader.loadConfig(SpecConfigLoader.java:56) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.config.SpecConfigLoader.loadConfig(SpecConfigLoader.java:47) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.spec.SpecFactory.create(SpecFactory.java:40) ~[teku-ethereum-spec-23.6.1.jar:23.6.1]
at tech.pegasys.teku.networks.Eth2NetworkConfiguration$Builder.build(Eth2NetworkConfiguration.java:256) ~[teku-ethereum-networks-23.6.1.jar:23.6.1]
at tech.pegasys.teku.config.TekuConfiguration$Builder.build(TekuConfiguration.java:202) ~[teku-23.6.1.jar:23.6.1]
at tech.pegasys.teku.cli.BeaconNodeCommand.tekuConfiguration(BeaconNodeCommand.java:414) ~[teku-23.6.1.jar:23.6.1]
... 14 more
Missing value for spec constant 'GOSSIP_MAX_SIZE'

This PR just adds all the settings that teku needs to the genesis config.
Values are actual mainnet values that have been used in our network ever since, so there is no actual change.

@pk910 pk910 merged commit e526614 into master Aug 27, 2023
1 check passed
@pk910 pk910 deleted the teku-fix branch October 6, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant