Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump deps #875

Merged
merged 1 commit into from
Feb 17, 2025
Merged

*: bump deps #875

merged 1 commit into from
Feb 17, 2025

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Feb 17, 2025

node-datachannel strangly fails in recent builds. hopefully bumping deps will fix that. it did 🚀 the central issue is that [email protected] (used by node-datachannel) had a broken NAPI detection

while at it: bump major immutable, msgpack (not stable because still broken in browser) and a bunch of misc pkgs

@tharvik tharvik added the bug Something isn't working label Feb 17, 2025
@tharvik tharvik marked this pull request as ready for review February 17, 2025 13:21
@tharvik tharvik requested a review from JulienVig February 17, 2025 13:21
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thanks for the quick fix and the updates!

I see a lot of unnecessary indents could you check if you're adding whitespace?

@tharvik tharvik merged commit ce82d37 into develop Feb 17, 2025
23 checks passed
@tharvik tharvik deleted the bump-deps branch February 17, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants