Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decentralized users to join late and catch up #775

Merged
merged 56 commits into from
Oct 14, 2024
Merged

Allow decentralized users to join late and catch up #775

merged 56 commits into from
Oct 14, 2024

Commits on Oct 9, 2024

  1. Rename Base to Aggregator and simplify event cycle

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e3894fc View commit details
    Browse the repository at this point in the history

  2. Update aggregator test

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8a6df7d View commit details
    Browse the repository at this point in the history

  3. Clarify todo

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    abcb3a3 View commit details
    Browse the repository at this point in the history

  4. Simplify receiving a weight update

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0e04d59 View commit details
    Browse the repository at this point in the history

  5. Simplify log

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    aa37b7e View commit details
    Browse the repository at this point in the history

  6. include aggregation round and communication round in decentralized me… 

    …ssages
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c558494 View commit details
    Browse the repository at this point in the history

  7. Rename Training to TrainingSteps

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b8578e8 View commit details
    Browse the repository at this point in the history

  8. Update round status messages

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1770f5c View commit details
    Browse the repository at this point in the history

  9. Add comment for non-awaited promised

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e2bbf60 View commit details
    Browse the repository at this point in the history

  10. Extend discojs EventEmitter

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bc2be30 View commit details
    Browse the repository at this point in the history

  11. Handle async listener and running listener on past events

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    74c1803 View commit details
    Browse the repository at this point in the history

  12. update event emitter subscription

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7709a9d View commit details
    Browse the repository at this point in the history

  13. Update decentralized payload message

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    65bac8c View commit details
    Browse the repository at this point in the history

  14. Fix import rename

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0057353 View commit details
    Browse the repository at this point in the history

  15. Fix linting error

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4bec8c7 View commit details
    Browse the repository at this point in the history

  16. Update decentralized round status

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7620ae3 View commit details
    Browse the repository at this point in the history

  17. Put messages in common between federated and decentralized

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d0e6380 View commit details
    Browse the repository at this point in the history

  18. Move participant management logic to parent class

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e2d9a28 View commit details
    Browse the repository at this point in the history

  19. Make peers wait when not enough participants

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    61aeb90 View commit details
    Browse the repository at this point in the history

  20. Move participant waiting to parent class

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8a76aa3 View commit details
    Browse the repository at this point in the history

  21. Replace private keywords by private fields

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9d1fe7e View commit details
    Browse the repository at this point in the history

  22. Add a new JoinRound decentralized message

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d5815ae View commit details
    Browse the repository at this point in the history

  23. Enable peers to join/leave mid session. Establish p2p connection in o… 

    …nRoundEndCommunication
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    95740ca View commit details
    Browse the repository at this point in the history

  24. Rm unused decentralizedSecure parameter

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    40efe48 View commit details
    Browse the repository at this point in the history

  25. Specify aggregation strategy in default tasks

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e5b0ab3 View commit details
    Browse the repository at this point in the history

  26. rm commented code

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    99b8661 View commit details
    Browse the repository at this point in the history

  27. Add more FAQ troubleshooting

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    53d10c9 View commit details
    Browse the repository at this point in the history

  28. Fix decentralized participant number

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    311ec60 View commit details
    Browse the repository at this point in the history

  29. Test client status

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    119b7c6 View commit details
    Browse the repository at this point in the history

  30. discojs/src/aggregator/aggregator: clean code following @tharvik's co… 

    …mments
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f374212 View commit details
    Browse the repository at this point in the history

  31. discojs/src/aggregator: rm unused methods

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6bcd84b View commit details
    Browse the repository at this point in the history

  32. discojs/src/aggregator/mean.spec: inline client names

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7272d36 View commit details
    Browse the repository at this point in the history

  33. discojs/src/aggregator/mean.spec: move away from time-based tests

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    750fada View commit details
    Browse the repository at this point in the history

  34. discojs/src/aggregator: split add method into common public add and p… 

    …rotected abstract _add
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9c62cb7 View commit details
    Browse the repository at this point in the history

  35. discojs/src/client: change this.shortID method to shortenID function

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    05d0567 View commit details
    Browse the repository at this point in the history

  36. discojs/src/client: rename checkIfWaitForParticipants to waitForParti… 

    …cipantsIfNeeded
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6d88cac View commit details
    Browse the repository at this point in the history

  37. discojs/src/client/decentralized/decentralized_client: get rid of rou… 

    …ndParticipants and stop resetting the nodes list at the end of round
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9941dfd View commit details
    Browse the repository at this point in the history

  38. discojs/src/client/decentralized/decentralized_client: send payloads … 

    …with forEach instead of map
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d931ad6 View commit details
    Browse the repository at this point in the history

  39. discojs/client/decentralized_client: save and emit "connecting to pee… 

    …rs" before waiting for participants if needed
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fd82f63 View commit details
    Browse the repository at this point in the history

  40. server/tests/e2e: rely on a Queue to test RoundStatus

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    be0b2a3 View commit details
    Browse the repository at this point in the history

  41. discojs/src/client|trainer: Make getNbOfParticipant parent method abs… 

    …tract to enforce subclass override
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    28f0422 View commit details
    Browse the repository at this point in the history

  42. discojs/src/default_tasks/mnist: make MNIST task use secure aggregation

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    066343f View commit details
    Browse the repository at this point in the history

  43. server/decentralized_controllers: rename checkThenSendPeersForRound t… 

    …o sendPeersForRoundIfNeeded
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bcf2eca View commit details
    Browse the repository at this point in the history

  44. server/federated_controller: use await instead of then

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    531e20e View commit details
    Browse the repository at this point in the history

  45. server/decentralized_controller: invert condition to exit early

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3a6e794 View commit details
    Browse the repository at this point in the history

  46. server/controllers: create common sendWaitForMoreParticipantsMsg method

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1c3f61c View commit details
    Browse the repository at this point in the history

  47. server/controllers: clean checkIfEnoughParticipants and rename to sen… 

    …dEnoughParticipantsMsgIfNeeded
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6438d41 View commit details
    Browse the repository at this point in the history

  48. server/src: rename TaskInitializer to TaskSet

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ee437e4 View commit details
    Browse the repository at this point in the history

  49. server/tests/e2e/decentralized.spec: avoid casting as RoundLogs

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b5449fd View commit details
    Browse the repository at this point in the history

  50. *: renaming round statuses to lowercase

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d44b786 View commit details
    Browse the repository at this point in the history

  51. webapp/Trainer.vue: convert roundStatus type from string to [RoundSta… 

    …tus, string]
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5d20ac9 View commit details
    Browse the repository at this point in the history

  52. *: Provide initial tasks to the server when calling serve instead o… 

    …f the constructor and get rid of the static async server constructor
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e2314c6 View commit details
    Browse the repository at this point in the history

  53. *: remove past event subscription on EventEmitter (now that tasks are… 

    … added after routers are initialized)
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    85b60a9 View commit details
    Browse the repository at this point in the history

  54. *: make aggregator.add check if contribution is valid

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5c960cb View commit details
    Browse the repository at this point in the history

  55. *: Make aggregator.add return void to enforce listening to the 'agg… 

    …regation' event to get the aggregated weights
    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    dfb607d View commit details
    Browse the repository at this point in the history

  56. *: enforce using override keyword

    @JulienVig
    JulienVig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d75338a View commit details
    Browse the repository at this point in the history