Improves and fixes the web-client UI #668

JulienVig · 2024-05-03T14:31:19Z

Addresses parts of #627 #628, #662, #665 and various things noted while working on the LUS COVID demo

Rework website navigation to make it more intuitive. Home page now links to tutorial information, existing tasks and custom task creation. The sidebar links to the home page, existing tasks, task creation, model evaluation, model library and the tutorial information. Settings has been merged with model library (since it only had the model library toggle button)
Add error handling when selected data (e.g. wrong CSV header, image file not found in CSV labels etc)
Removed pre-defined tasks geotags and skin mnist because no data is provided and training has not been not tested
Harmonize the outdated tutorial information UI with the rest of the website.
Remove l18n internationalization plugin, only english is currently used and there are no plans to add new languages.

Rework ModelCaching, current behavior now explicit and card moved to training page

Improve the training charts with loss plots, tooltip, and dynamic y axis range

Add an explanation on what pre-defined "DISCOllaboratives" are

inform users on where the dataset is kept #665 Specifies that data is not uploaded anywhere

Addresses #627
Addresses #628
Addresses #662
Addresses #665

…yinformation

tharvik

wow, a fresher and clearer interface, great work! ✨

as usual, nothing blocking, only a few comments

good idea to remove i18n, it's was barely used anyway
and rm useles tests on Landing is a nice too
for the geotags & skin_mnist task, nothing to salvage?

tharvik · 2024-05-08T08:35:43Z

discojs/discojs-core/src/default_tasks/cifar10.ts

@@ -17,7 +17,8 @@ export const cifar10: TaskProvider = {
        tradeoffs: 'Training success strongly depends on label distribution',
        dataFormatInformation: 'Images should be of .png format and of size 32x32. <br> The label file should be .csv, where each row contains a file_name, class.  <br> <br> e.g. if you have images: 0.png (of a frog) and 1.png (of a car) <br> labels.csv contains: (Note that no header is needed)<br> 0.png, frog <br> 1.png, car',
        dataExampleText: 'Below you can find 10 random examples from each of the 10 classes in the dataset.',
-        dataExampleImage: 'https://storage.googleapis.com/deai-313515.appspot.com/example_training_data/cifar10-example.png'
+        dataExampleImage: 'https://storage.googleapis.com/deai-313515.appspot.com/example_training_data/cifar10-example.png',
+        sampleDatasetLink: 'https://www.kaggle.com/competitions/cifar-10/data'


consider adding that to datasets/populate instead of pulling from our own archive

Would it work when the webapp is deployed? I think datasets/populate can only be used in local isn't it?

correct, do keep it in cifar10's Task and add it to datasets/populate so that we ensure that we also train our tests with the sample dataset.

Ah so some cifar10 data is already included in the example_training_data (which requires manipulation to used in the webapp...) but I wanted to provide a public facing link too.

discojs/discojs-core/src/task/display_information.ts

discojs/discojs-node/src/data/image_loader.spec.ts

cli/src/data.ts

server/tests/e2e/federated.spec.ts

web-client/src/components/training/Trainer.vue

web-client/src/components/training/TrainingInformation.vue

Co-authored-by: Valérian Rousset <[email protected]>

JulienVig · 2024-05-08T13:09:01Z

for the geotags & skin_mnist task, nothing to salvage?

There is a map modal implemented in Tester.vue for the geotag task which can be interesting but it relies on https://disco-polygon.web.app/ which doesn't exist anymore. I couldn't find what was the training data and with the base map missing I'm going to remove the task. It would be interesting to keep it in mind and go back to it if we ever want to implement another location based task
The skin mnist is very similar to LUS Covid but multi-class classification. I don't think it's worth uploading a new sample dataset and some work is required to create a correct CSV file to use the kaggle dataset in Disco

JulienVig · 2024-05-08T13:25:56Z

@tharvik It looks like the npm deployment broke the build-server-docker action?

tharvik · 2024-05-08T18:44:09Z

@tharvik It looks like the npm deployment broke the build-server-docker action?

looks like upstream released a broken nodejs version, followup there. openned a PR fixing that #672

JulienVig added 3 commits May 3, 2024 14:30

Remove list filters in the predefined tasks web-client page

9faab14

Tmp: save cache model use toggle button

44750f2

Rework ModelCaching and move it to Trainer rather than task description

880ef11

JulienVig self-assigned this May 3, 2024

JulienVig marked this pull request as draft May 3, 2024 14:32

Add loss charts to the web-client training informations

b35d72e

JulienVig changed the title ~~662 improve tasks julien~~ Improves and fixes the pre-defined task UI May 3, 2024

JulienVig added 15 commits May 6, 2024 11:46

Clean and refactor default tasks tests

9aa6d0c

Fix web-client and docs/example tests

f3aa68a

Add pre-defined task description and fix mlo logo

449e994

Add data selection description

6af385d

Remove some default tasks and add sample dataset links in task displa…

aac0863

…yinformation

Reword home page text

e3aa0b4

Bug fix and add error handling to data selection UI

874292b

Fix web-client task test

bfad11e

Fix discojs-node image loader test

dcef3f5

Move model library toggle button to the model library panel

22e7ed2

Add hover description to model library buttons

4ae7f12

Add new sidebar links to custom task and model evaluation

5d1959d

Move the about us section to the footer MLO logo

1289096

Harmonize UI design on information page with the rest of the web-client

6752003

Fix web-client unused import

2413e48

JulienVig changed the title ~~Improves and fixes the pre-defined task UI~~ Improves and fixes the web-client UI May 7, 2024

JulienVig added 2 commits May 7, 2024 15:01

Fix Cifar10 test

87e0ffe

Remove i18n internationalizaion plugin

d7abb74

JulienVig marked this pull request as ready for review May 7, 2024 15:58

JulienVig requested a review from tharvik May 7, 2024 15:58

tharvik approved these changes May 8, 2024

View reviewed changes

JulienVig and others added 2 commits May 8, 2024 13:53

Make display_information dataset link a URL type

75ddf94

Co-authored-by: Valérian Rousset <[email protected]>

Update cli/src/data.ts with Repeat rather than Range

a90d6c7

Co-authored-by: Valérian Rousset <[email protected]>

JulienVig and others added 11 commits May 8, 2024 13:55

Update image_loader.spec.ts with Repeat rather than Range

98ded2b

Co-authored-by: Valérian Rousset <[email protected]>

Update federated.spec.ts with Repeat rather than Range

e21f60e

Co-authored-by: Valérian Rousset <[email protected]>

Update web-client/src/components/data/dataset_input/DatasetInput.vue

73c107c

Co-authored-by: Valérian Rousset <[email protected]>

Update web-client/src/components/training/TrainingInformation.vue

d7c6b10

Co-authored-by: Valérian Rousset <[email protected]>

Update web-client/src/components/training/TrainingInformation.vue

4d9ad94

Co-authored-by: Valérian Rousset <[email protected]>

Make task information URLs type URL

c66925d

Make training logs scrollable

4696c84

Rollback url as type string but add URL checks

06378a8

Make buttons wrap when screen not wide enough

2e7db2e

Add buttons wrap

ec26c8f

Remove geotag label logic remnants

aed256d

JulienVig added 2 commits May 8, 2024 15:18

Remove unused task tradeoffs and limitations

b6ef8e5

Add missing Repeat import

708dae6

Update Aobut Us design

1ae94e3

Merge branch 'develop' into 662-improve-tasks-julien

7b301c5

JulienVig merged commit d454f30 into develop May 13, 2024
23 checks passed

JulienVig deleted the 662-improve-tasks-julien branch May 13, 2024 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improves and fixes the web-client UI #668

Improves and fixes the web-client UI #668

JulienVig commented May 3, 2024 •

edited

Loading

tharvik left a comment •

edited

Loading

tharvik May 8, 2024

JulienVig May 8, 2024

tharvik May 8, 2024

JulienVig May 8, 2024

JulienVig commented May 8, 2024 •

edited

Loading

JulienVig commented May 8, 2024

tharvik commented May 8, 2024

Improves and fixes the web-client UI #668

Improves and fixes the web-client UI #668

Conversation

JulienVig commented May 3, 2024 • edited Loading

tharvik left a comment • edited Loading

Choose a reason for hiding this comment

tharvik May 8, 2024

Choose a reason for hiding this comment

JulienVig May 8, 2024

Choose a reason for hiding this comment

tharvik May 8, 2024

Choose a reason for hiding this comment

JulienVig May 8, 2024

Choose a reason for hiding this comment

JulienVig commented May 8, 2024 • edited Loading

JulienVig commented May 8, 2024

tharvik commented May 8, 2024

JulienVig commented May 3, 2024 •

edited

Loading

tharvik left a comment •

edited

Loading

JulienVig commented May 8, 2024 •

edited

Loading