Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a NextJS frontend for training GPT on wikitext and executing some web text dataset related tests #620

Closed

Conversation

peacefulotter
Copy link
Collaborator

This PR adds another frontend to Disco, this time written in NextJS. The reason is simply because I do not know Vue at all while I am quite familiar with NextJS.
In any case, I believe the Vue frontend should in turn entirely move to NextJS as it appears to be much better (and modern) in general, but this is more of a personal opinion.

@JulienVig
Copy link
Collaborator

Closing as there is no foreseeable need to support another frontend framework and the PR still requires some work before being able to be merged

@JulienVig JulienVig closed this May 13, 2024
@peacefulotter
Copy link
Collaborator Author

Noooo NextJS >>>
Are there plans to change the frontend framework or no need in the end?

@JulienVig
Copy link
Collaborator

This is currently no plan to integrate another one. Migrating away from vusjs to nextjs would require re-implementing all the UI features again which is definitely not a priority, though you're welcome to work on this if you want!

@peacefulotter
Copy link
Collaborator Author

If you have some ideas on the future frontend components and use cases, I could try to see if it's worth migrating to NextJS and even contribute for sure. Right now, the UI does not look too professional imho but I don't know if this will ever be an important criteria

@JulienVig
Copy link
Collaborator

Having a good-looking frontend is important! I would really appreciate your feedback on what's not looking professional right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants