fixup! tmp: debug github actions

epfml · Dec 2, 2024 · d6c9e65 · d6c9e65
1 parent 3e8a3d5
commit d6c9e65
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/discojs/src/client/client.ts b/discojs/src/client/client.ts
@@ -178,10 +178,7 @@ export abstract class Client extends EventEmitter<{'status': RoundStatus}>{
     url.pathname += `tasks/${this.task.id}/model.json`
 
     const response = await fetch(url);
-    if (!response.ok) {
-      console.log("Error with response ok")
-      throw new Error(`fetch: HTTP status ${response.status}`);
-    }
+    if (!response.ok) throw new Error(`fetch: HTTP status ${response.status}`);
 
     const encoded = new Uint8Array(await response.arrayBuffer())
     return await serialization.model.decode(encoded)

diff --git a/discojs/src/task/task_handler.ts b/discojs/src/task/task_handler.ts
@@ -28,20 +28,14 @@ export async function pushTask<D extends DataType>(
       weights: await serialization.weights.encode(model.weights),
     }),
   });
-  if (!response.ok) {
-    console.log("Error with response ok")
-    throw new Error(`fetch: HTTP status ${response.status}`);
-  }
+  if (!response.ok) throw new Error(`fetch: HTTP status ${response.status}`);
 }
 
 export async function fetchTasks(
   base: URL,
 ): Promise<Map<TaskID, Task<DataType>>> {
   const response = await fetch(urlToTasks(base));
-  if (!response.ok) {
-    console.log("Error with response ok")
-    throw new Error(`fetch: HTTP status ${response.status}`);
-  }
+  if (!response.ok) throw new Error(`fetch: HTTP status ${response.status}`);
   const tasks: unknown = await response.json();
 
   if (!Array.isArray(tasks)) {

diff --git a/webapp/src/components/testing/__tests__/Testing.spec.ts b/webapp/src/components/testing/__tests__/Testing.spec.ts
@@ -60,7 +60,7 @@ it("shows stored models", async () => {
 it("allows to download server's models", async () => {
   vi.stubGlobal("fetch", async (url: string | URL) => {
     if (url.toString() === "http://localhost:8080/tasks")
-      return { ok: () => true, json: () => Promise.resolve([TASK]) };
+      return { json: () => Promise.resolve([TASK]) };
     throw new Error(`unhandled get: ${url}`);
   });
   afterEach(() => {