forked from kubernetes-sigs/kueue
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
251 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| Copyright 2022 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/klog/v2" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook" | ||
| ) | ||
|
|
||
| const ( | ||
| DefaultPodSetName = "main" | ||
| ) | ||
|
|
||
| // log is for logging in this package. | ||
| var workloadlog = ctrl.Log.WithName("workload-webhook") | ||
|
|
||
| func (r *Workload) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewWebhookManagedBy(mgr). | ||
| For(r). | ||
| Complete() | ||
| } | ||
|
|
||
| // +kubebuilder:webhook:path=/mutate-kueue-x-k8s-io-v1alpha1-workload,mutating=true,failurePolicy=fail,sideEffects=None,groups=kueue.x-k8s.io,resources=workloads,verbs=create;update,versions=v1alpha1,name=mworkload.kb.io,admissionReviewVersions=v1 | ||
|
|
||
| var _ webhook.Defaulter = &Workload{} | ||
|
|
||
| // Default implements webhook.Defaulter so a webhook will be registered for the type | ||
| func (r *Workload) Default() { | ||
| workloadlog.V(5).Info("defaulter", "workload", klog.KObj(r)) | ||
|
|
||
| for i := range r.Spec.PodSets { | ||
| podSet := &r.Spec.PodSets[i] | ||
| if len(podSet.Name) == 0 { | ||
| podSet.Name = DefaultPodSetName | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // +kubebuilder:webhook:path=/validate-kueue-x-k8s-io-v1alpha1-workload,mutating=false,failurePolicy=fail,sideEffects=None,groups=kueue.x-k8s.io,resources=workloads,verbs=create;update,versions=v1alpha1,name=vworkload.kb.io,admissionReviewVersions=v1 | ||
|
|
||
| var _ webhook.Validator = &Workload{} | ||
|
|
||
| // ValidateCreate implements webhook.Validator so a webhook will be registered for the type | ||
| func (r *Workload) ValidateCreate() error { | ||
| return nil | ||
| } | ||
|
|
||
| // ValidateUpdate implements webhook.Validator so a webhook will be registered for the type | ||
| func (r *Workload) ValidateUpdate(old runtime.Object) error { | ||
| return nil | ||
| } | ||
|
|
||
| // ValidateDelete implements webhook.Validator so a webhook will be registered for the type | ||
| func (r *Workload) ValidateDelete() error { | ||
| return nil | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| Copyright 2022 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "context" | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| "github.com/onsi/ginkgo/v2" | ||
| "github.com/onsi/gomega" | ||
| "k8s.io/client-go/rest" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/manager" | ||
|
|
||
| kueuev1alpha1 "sigs.k8s.io/kueue/apis/kueue/v1alpha1" | ||
| "sigs.k8s.io/kueue/test/integration/framework" | ||
| // +kubebuilder:scaffold:imports | ||
| ) | ||
|
|
||
| var ( | ||
| cfg *rest.Config | ||
| k8sClient client.Client | ||
| fwk *framework.Framework | ||
| ctx context.Context | ||
| ) | ||
|
|
||
| func TestAPIs(t *testing.T) { | ||
| gomega.RegisterFailHandler(ginkgo.Fail) | ||
| ginkgo.RunSpecs(t, | ||
| "Webhook Suite", | ||
| ) | ||
| } | ||
|
|
||
| var _ = ginkgo.BeforeSuite(func() { | ||
| fwk = &framework.Framework{ | ||
| CRDPath: filepath.Join("..", "..", "..", "..", "config", "crd", "bases"), | ||
| WebhookPath: filepath.Join("..", "..", "..", "..", "config", "webhook"), | ||
| ManagerSetup: func(mgr manager.Manager, ctx context.Context) { | ||
| err := (&kueuev1alpha1.Workload{}).SetupWebhookWithManager(mgr) | ||
| gomega.Expect(err).NotTo(gomega.HaveOccurred()) | ||
| }, | ||
| } | ||
| ctx, cfg, k8sClient = fwk.Setup() | ||
| }) | ||
|
|
||
| var _ = ginkgo.AfterSuite(func() { | ||
| fwk.Teardown() | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| Copyright 2022 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "github.com/onsi/ginkgo/v2" | ||
| "github.com/onsi/gomega" | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
|
|
||
| "sigs.k8s.io/kueue/apis/kueue/v1alpha1" | ||
| "sigs.k8s.io/kueue/pkg/util/testing" | ||
| "sigs.k8s.io/kueue/test/integration/framework" | ||
| ) | ||
|
|
||
| var ns *corev1.Namespace | ||
|
|
||
| var _ = ginkgo.BeforeEach(func() { | ||
| ns = &corev1.Namespace{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| GenerateName: "core-", | ||
| }, | ||
| } | ||
| gomega.Expect(k8sClient.Create(ctx, ns)).To(gomega.Succeed()) | ||
| }) | ||
|
|
||
| var _ = ginkgo.AfterEach(func() { | ||
| gomega.Expect(framework.DeleteNamespace(ctx, k8sClient, ns)).To(gomega.Succeed()) | ||
| }) | ||
|
|
||
| var _ = ginkgo.Describe("Workload defaulting webhook", func() { | ||
| ginkgo.Context("When creating Workload", func() { | ||
| ginkgo.It("Should set default values", func() { | ||
| ginkgo.By("Creating a new Workload") | ||
| workload := testing.MakeWorkload("workload1", ns.Name).Obj() | ||
| workload.Spec.PodSets = []v1alpha1.PodSet{ | ||
| { | ||
| Count: 2, | ||
| Spec: corev1.PodSpec{ | ||
| Containers: []corev1.Container{ | ||
| { | ||
| Name: "test", | ||
| Image: "fake-image", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| gomega.Expect(k8sClient.Create(ctx, workload)).Should(gomega.Succeed()) | ||
|
|
||
| created := &v1alpha1.Workload{} | ||
| gomega.Expect(k8sClient.Get(ctx, types.NamespacedName{ | ||
| Name: workload.Name, | ||
| Namespace: workload.Namespace, | ||
| }, created)).Should(gomega.Succeed()) | ||
|
|
||
| gomega.Expect(created.Spec.PodSets[0].Name).Should(gomega.Equal(v1alpha1.DefaultPodSetName)) | ||
| }) | ||
| }) | ||
| }) |