Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5942 - Update the representation of sense and antisense chains in sequence mode (1/2) #6388

Merged
merged 33 commits into from
Feb 4, 2025
Merged

#5942 - Update the representation of sense and antisense chains in sequence mode (1/2) #6388

merged 33 commits into from
Feb 4, 2025

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jan 29, 2025 •
edited
Loading

Closes #5942

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

This was linked to issues Jan 30, 2025
Unknown monomer and CHEM overlap to each other if both are the side chain for same chain #6194
Closed
Nucleotide wronly become antisense oriented if have hydrogen connection to sugar #6195
Closed
@rrodionov91
- POC for sequence mode caret
4427616
@rrodionov91
- POC for sequence mode caret
00bb44c
@rrodionov91
- POC for sequence mode caret
7d0efaf
@rrodionov91
- initial implementation of antisense in sequence mode
531434a
@rrodionov91
- implemented getAlignedSenseAntisenseChains
225f18d
@rrodionov91
- implemented getAlignedSenseAntisenseChainItems
006a8be
@rrodionov91
- started SequenceViewModel implementation
57f62b6
@rrodionov91
- reworked sequence mode to work with SequenceViewModel in
16d3d07 
- implemented work with backbone nodes in sequence mode
- fixed types
@rrodionov91
- fixed empty sequence mode
f9ff43c 
- fixed sequence nodes modification in rna builder
@rrodionov91
- fixed types
a5bf408
@rrodionov91
- updated screenshots
f8b8745
@rrodionov91
- fixed remove new sequence btns call
20b89b7
@rrodionov91
- updated screenshots
72459ed
@rrodionov91
- updated screenshots
93651d3
@rrodionov91
- fixed delete for antisense
06822cf 
- fixed clicking between antisense nodes
- fixed add new sequence btn position
- removed antisense cursor blinking
@rrodionov91
- fixed issues founded in self-review
06a5b16
@rrodionov91
- fixed issues founded in self-review
67e02e5
@rrodionov91 rrodionov91 force-pushed the 5942-Update_the_representation_of_sense_and_antisense_chains_in_sequence_mode branch from 799531c to 67e02e5 Compare February 2, 2025 21:37
@rrodionov91 rrodionov91 linked an issue Feb 3, 2025 that may be closed by this pull request
Circular hydrogen bond connection between three (or more) chains, those hydrogen bonds isn't considered as side chain connection for layout purposes #6201
Closed
@rrodionov91 rrodionov91 merged commit 9ad6172 into master Feb 4, 2025
10 checks passed
@rrodionov91 rrodionov91 deleted the 5942-Update_the_representation_of_sense_and_antisense_chains_in_sequence_mode branch February 4, 2025 19:55
@rrodionov91 rrodionov91 linked an issue Feb 6, 2025 that may be closed by this pull request
Cursor position after adding preset in sequence mode causes an incorrect sequence formation #6272
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svvald svvald svvald approved these changes

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rrodionov91 @svvald