Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6161 - Stereo flags are displayed despite enabling 'Ignore chiral flag' in MOL V2000 files #6179

Merged
merged 5 commits into from
Dec 23, 2024
Merged

#6161 - Stereo flags are displayed despite enabling 'Ignore chiral flag' in MOL V2000 files #6179

merged 5 commits into from
Dec 23, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Dec 19, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91 rrodionov91 linked an issue Dec 19, 2024 that may be closed by this pull request
Stereo flags are displayed despite enabling 'Ignore chiral flag' in MOL V2000 files #6161
Closed
@rrodionov91
- fixed build
1e45812
@rrodionov91
Revert "- fixed build"
c3e7c42 
This reverts commit 1e45812.
@rrodionov91
Revert "#6161 - Stereo flags are displayed despite enabling 'Ignore c…
6f8585f 
…hiral flag' in MOL V2000 files"

This reverts commit 9d373b1.
@rrodionov91
#6161 - S-group in the middle of a chain does not expand when opening…
2461336 
… an SDF V3000 file

- added ignoreChiralFlag parameter to be used in mol v2000 deserialization during setMolecule and openning files methods
- removed ignoreChiralFlag parameter from serialization
@rrodionov91 rrodionov91 merged commit a4b623b into release/2.28 Dec 23, 2024
3 checks passed
@rrodionov91 rrodionov91 deleted the 6161-Stereo_flags_are_displayed_despite_enabling_'Ignore_chiral_flag'_in_MOL_V2000_files_ branch December 23, 2024 15:22
rrodionov91 added a commit that referenced this pull request Dec 23, 2024
@rrodionov91
#6161 - Stereo flags are displayed despite enabling 'Ignore chiral fl…
2030475 
…ag' in MOL V2000 files (#6179)

- added ignoreChiralFlag parameter to be used in mol v2000 deserialization during setMolecule and openning files methods
- removed ignoreChiralFlag parameter from serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svvald svvald svvald approved these changes

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stereo flags are displayed despite enabling 'Ignore chiral flag' in MOL V2000 files
2 participants
@rrodionov91 @svvald