Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align Application namespace creation and readme script(#213) #230

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

alezander86
Copy link

Description:

This pull request updates the values files for the App of Apps structure by modifying the namespace definitions for multiple applications. The changes ensure that namespace values are sourced correctly from values.yaml, making them more flexible and consistent. If any additional updates are required for other applications, they should follow this structure.

Additionally, the Makefile script has been updated to modify the README table of applications, adding a new column with the namespace name.

Fixes (#213)

Type of change

  • Enhancement (non-breaking change which improves an existing feature or documentation)

How Has This Been Tested?

Verified that the Helm templates render correctly with helm template.
Confirmed successful ArgoCD sync without errors.

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@alezander86 alezander86 self-assigned this Feb 11, 2025
@alezander86 alezander86 requested a review from a team as a code owner February 11, 2025 18:17
@alezander86 alezander86 added enhancement New feature or request documentation Improvements or additions to documentation labels Feb 11, 2025
@SergK SergK merged commit 3c89665 into main Feb 12, 2025
1 check passed
@SergK SergK deleted the EPMDEDP-14964 branch February 12, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants