Migrate runs to archive table according to user/group configuration - dry-run #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinPavel
requested changes
Aug 22, 2024
| @@ -93,6 +96,9 @@ public class PipelineRunDao extends NamedParameterJdbcDaoSupport { | |||
| @Autowired | |||
| private RunServiceUrlDao serviceUrlDao; | |||
|
|
|||
| @Autowired | |||
There was a problem hiding this comment.
would it be possible to inherit from this class instead of have it as dep? And then, you can move 1686-1689 lines to JdbcTemplateReadOnlyWrapper. it should slightly reduce number of copy-paste lines in a future, when we will reuse this approach for other DAOs, if needed.
P.S. with this approach it would be better to rename JdbcTemplateReadOnlyWrapper as JdbcTemplateWithDryRunWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #3619
Provides ability to enable
dry-runregime usingsystem.archive.run.dry-run.regimesystem property (default: off).