Issue 3602 Pod nework bandwidth usage #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need new configs in |
SilinPavel
reviewed
Jul 17, 2024
| @@ -133,7 +139,8 @@ static class ResourceMonitoringManagerCore { | |||
| final PreferenceManager preferenceManager, | |||
| final StopServerlessRunManager stopServerlessRunManager, | |||
| final InstanceOfferManager instanceOfferManager, | |||
| final RunStatusManager runStatusManager) { | |||
| final RunStatusManager runStatusManager, | |||
| final ESMonitoringManager monitoringManager) { | |||
There was a problem hiding this comment.
let's use already existing way to request metrics (same as for IdleRuns). For this we need implement a method for NetworkRequester.java which now is unimplemented + AbstractMetricRequester.getRequester should be expanded to return NetworkRequester if such metric is requested
SilinPavel
force-pushed
the
Issue_3602_Pod_nework_bandwidth_usage
branch
from
b61e0c0 to
a016ffb
Compare
SilinPavel
pushed a commit
that referenced
this pull request
Aug 28, 2024
(cherry picked from commit cdb4be4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pod nework bandwidth usage