Issue 3573 - Introduce hard/soft limits for commiting run and run tool/pipeline #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinPavel
requested changes
Jul 2, 2024
| try { | ||
| Assert.notNull(containerId, | ||
| messageHelper.getMessage(MessageConstants.ERROR_CONTAINER_ID_FOR_RUN_NOT_FOUND, run.getId())); | ||
| final String getSizeCommand = DockerContainerLayersCommand.builder() |
There was a problem hiding this comment.
Now, when we use this class in several situations, not only to get layers, I think it would be right to rename it. How about SimpleDockerContainerCommand since it basically can be any command that doesn't have other parameters except containerId and scriptUrl?
| .getCommand(); | ||
| Process sshConnection = submitCommandViaSSH(run.getInstance().getNodeIP(), getSizeCommand, | ||
| getSshPort(run)); | ||
| try (BufferedReader reader = new BufferedReader(new InputStreamReader(sshConnection.getInputStream()))) { |
There was a problem hiding this comment.
I think we need to wait with sshConnection.waitFor then check for success before collecting an output, because this collecting is blocking operation and we can have a risk to block here forever
| final String result = reader.lines().collect(Collectors.joining()); | ||
| size = Long.parseLong(result); | ||
| } | ||
| boolean isFinished = sshConnection.waitFor( |
| .containerId(containerId) | ||
| .build() | ||
| .getCommand(); | ||
| Process sshConnection = submitCommandViaSSH(run.getInstance().getNodeIP(), getSizeCommand, |
…l/pipeline - fix remarks
…l/pipeline - preferences values in bytes + commit check result data structure change
…l/pipeline - preferences values in bytes + commit check result data structure change
…l/pipeline - preferences values in bytes + commit check result data structure change
SilinPavel
force-pushed
the
Issue_3573_Introduce_hard/soft_limits_for_commiting_run_and_run_tool/pipeline
branch
3 times, most recently
from
422d5b5 to
c4a235c
Compare
SilinPavel
force-pushed
the
Issue_3573_Introduce_hard/soft_limits_for_commiting_run_and_run_tool/pipeline
branch
from
c4a235c to
f90bde5
Compare
…_3573_Introduce_hard/soft_limits_for_commiting_run_and_run_tool/pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce hard/soft limits for commiting run and run tool/pipeline #3573