Gui improvements 08 11 23 #3432

maryvictol · 2024-01-26T14:00:57Z

The PR provides updates:

updates DetachedConfigurationsTest, NfsDataStorageTest
fix SLURMMasterSetup message
associate different description estimated price to common primitive ESTIMATED_PRICE
add Price cannot be estimated case handling
add restoring filters values after refresh in the getInfoRow method for SystemLoggingTest
update clearAndFillPipelineFile method

…aled cluster parameters to false)

Signed-off-by: Yulia Kamyshova <[email protected]>

kamyshova · 2024-04-17T08:15:05Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/LaunchLimitMountsTest.java

@@ -192,7 +192,8 @@ public void rerunPipelineWithoutLimitMounts() {
                .ensure(LIMIT_MOUNTS, text("All available non-sensitive storages"))
                .launch(this)
                .showLog(getLastRunId())
-                .ensureNotVisible(PARAMETERS)
+                .expandTab(PARAMETERS)
+                .ensureParameterIsNotPresent("CP_CAP_LIMIT_MOUNTS")


Could we extract "CP_CAP_LIMIT_MOUNTS" to constant and replace this

kamyshova · 2024-04-17T08:16:44Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/RunPipelineTest.java

@@ -18,6 +18,7 @@
 import static com.codeborne.selenide.Selectors.byClassName;


Clean up the unused import statements, please

kamyshova · 2024-04-17T08:18:17Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/SamplesMetadataTest.java

                .uploadFile(getFile(launchScript))
                .ensure(byText(launchScript), visible);
-        sleep(20, SECONDS);
+//        sleep(20, SECONDS);


Could this be cleaned?

kamyshova · 2024-04-17T08:29:34Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/SystemLoggingTest.java

@@ -142,15 +146,15 @@ public void userAuthenticationUnsuccessfulAttempt() {
                    .switchToSystemLogs();
            if (impersonateMode()) {
                systemLogsAO
-                        .filterByUser(admin.login)
+                        .filterByField("User", admin.login)


Let's extract "User" to constant and replace its everywhere

kamyshova · 2024-04-17T08:31:23Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/ao/LogAO.java

@@ -461,6 +461,7 @@ public static By parameterWithName(final String name, final String value) {
                ".//td[contains(., '%s')]]", name, value));
    }

+


Could be cleaned up?

kamyshova · 2024-04-17T08:38:06Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/ao/PipelineCodeTabAO.java

@@ -196,6 +199,18 @@ public PipelineCodeTabAO shouldContainFile(final String fileName) {
        return this;
    }

+    public PipelineCodeTabAO waitUntilSaveEnding() {


Can be private

kamyshova · 2024-04-17T08:40:32Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/ao/PipelineGraphTabAO.java

@@ -15,7 +15,9 @@
 */
 package com.epam.pipeline.autotests.ao;

+import static com.codeborne.selenide.Condition.exist;


Clean up the unused import statements, please

kamyshova · 2024-04-17T08:40:43Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/ao/PipelineGraphTabAO.java

 import com.codeborne.selenide.SelenideElement;
+import static com.epam.pipeline.autotests.utils.C.DEFAULT_TIMEOUT;


Clean up the unused import statements, please

kamyshova · 2024-04-17T08:54:01Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/ao/PipelineSelection.java

@@ -50,6 +53,7 @@ public PipelineSelection(final Configuration parentAO) {

    public PipelineSelection selectPipeline(final String pipeline) {
        this.pipeline = pipeline;
+        context().$(className("ant-table-content")).waitUntil(exist, DEFAULT_TIMEOUT);


Could this to be extracted to TABLE primitive?

kamyshova · 2024-04-17T08:59:33Z

e2e/gui/src/test/java/com/epam/pipeline/autotests/ao/SystemManagementAO.java

+            return $(filterBy("Message")).$(byXpath("./input"))
+                    .getAttribute("value");


Could this be better to extract filters to primitives?

…gui_improvements_08-11-23

Signed-off-by: Yulia Kamyshova <[email protected]>

maryvictol added 30 commits November 11, 2023 00:53

Update PermissionTabAO

9ebd00e

SystemLogging delete testUser before test

7f78f06

Update NfsDataStorageTest

6f370b2

Update NfsDataStorageTest

52a9d17

Update message for SLURMMasterSetup task

883b45e

Update RoleModelTest

a9f691b

Update RoleModelTest

f31b2f1

Update WDLPipelineTest

eb9cd85

Update WDLPipelineTest

7fe1260

Update ToolsTest

7a81054

Update PipelineCodeTabAO

e3d6332

Update DetachedConfigurationsTest

4e5e09e

Update DetachedConfigurationsTest

b0bfab8

unify ESTIMATED_PRICE

9516ae3

Update PipelineSelection

eba91e0

Update DetachedConfigurationsTest

2874834

Small fix

decde18

Update SystemManagementAO

6d3e225

Update SamlesMetadataTest

3dde6c8

update StorageRulesTest

a203191

update ToolsParametersTest

c7e99ed

Update SystemManagementAO

b8e0fb3

Update DetachedConfigurationsTest

730ba3f

Update DetachedConfigurationsTest

b3a7f55

Update assertPageTitleIs() method

51a61d2

Update PipelineConfigurationTabAO

f58ed0e

Update SamplesMetadataTest

50fbc90

Update SamplesMetadataTest

a60df52

Update SamplesMetadataTest

bd1dd22

Update PipelineEditingTest

014caa8

maryvictol added 7 commits January 25, 2024 11:58

Merge branch 'develop' into gui_improvements_08-11-23

32602ae

Small fix FolderNavigationTest

5dcd589

Small fix

fe0cf33

Update LaunchLimitMountsTest EPMCMBIBPC-2683 (set not-enabled auto-sc…

fc62a9a

…aled cluster parameters to false)

Update LaunchLimitMountsTest

bf35682

Update FolderNavigationTest

40ee1ab

Update FolderNavigationTest

8418523

maryvictol marked this pull request as ready for review April 11, 2024 10:51

maryvictol added the sys/e2e Issues related to the e2e tests automation label Apr 11, 2024

Refactor SystemManagementAO and clean up

d3e23b2

Signed-off-by: Yulia Kamyshova <[email protected]>

kamyshova requested changes Apr 17, 2024

View reviewed changes

maryvictol added 3 commits May 8, 2024 22:16

Update after review

0316676

Merge remote-tracking branch 'origin/gui_improvements_08-11-23' into …

c33fa48

…gui_improvements_08-11-23

Update Copyright

a343b03

maryvictol requested a review from kamyshova May 10, 2024 16:26

maryvictol and others added 2 commits May 14, 2024 14:18

small fix

80ee3f3

Clean up unused imports

cfc58a1

Signed-off-by: Yulia Kamyshova <[email protected]>

kamyshova approved these changes May 21, 2024

View reviewed changes

kamyshova merged commit 954baa7 into develop May 21, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gui improvements 08 11 23 #3432

Gui improvements 08 11 23 #3432

maryvictol commented Jan 26, 2024 •

edited

Loading

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

maryvictol May 8, 2024

kamyshova Apr 17, 2024

		@@ -18,6 +18,7 @@
		import static com.codeborne.selenide.Selectors.byClassName;

		@@ -461,6 +461,7 @@ public static By parameterWithName(final String name, final String value) {
		".//td[contains(., '%s')]]", name, value));
		}

		import com.codeborne.selenide.SelenideElement;
		import static com.epam.pipeline.autotests.utils.C.DEFAULT_TIMEOUT;

		return $(filterBy("Message")).$(byXpath("./input"))
		.getAttribute("value");

Gui improvements 08 11 23 #3432

Gui improvements 08 11 23 #3432

Conversation

maryvictol commented Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maryvictol commented Jan 26, 2024 •

edited

Loading