feat: support ingress.tls.hosts templating in dial-extension helm cha…

…rt (#86)
epam · Oct 21, 2024 · baee39e · baee39e
1 parent cfb4b2e
commit baee39e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/charts/dial-extension/Chart.yaml b/charts/dial-extension/Chart.yaml
@@ -21,4 +21,4 @@ maintainers:
 name: dial-extension
 sources:
   - https://github.com/epam/ai-dial-helm/tree/main/charts/dial-extension
-version: 1.0.5
+version: 1.0.6
diff --git a/charts/dial-extension/README.md b/charts/dial-extension/README.md
@@ -1,6 +1,6 @@
 # dial-extension
 
-![Version: 1.0.5](https://img.shields.io/badge/Version-1.0.5-informational?style=flat-square) ![AppVersion: 1.0](https://img.shields.io/badge/AppVersion-1.0-informational?style=flat-square)
+![Version: 1.0.6](https://img.shields.io/badge/Version-1.0.6-informational?style=flat-square) ![AppVersion: 1.0](https://img.shields.io/badge/AppVersion-1.0-informational?style=flat-square)
 
 Helm chart for dial extensions
 
@@ -124,7 +124,7 @@ helm install my-release dial/dial-extension -f values.yaml
 | ingress.path | string | `"/"` | Default path for the ingress record NOTE: You may need to set this to '/*' in order to use this with ALB ingress controllers |
 | ingress.pathType | string | `"Prefix"` | Ingress path type |
 | ingress.serviceName | string | `""` | Change default name of service for the ingress record |
-| ingress.tls | list | `[]` | TLS configuration for additional hostname(s) to be covered with this ingress record ref: https://kubernetes.io/docs/concepts/services-networking/ingress/#tls |
+| ingress.tls | list | `[]` | TLS configuration for additional hostname(s) to be covered with this ingress record (evaluated as a template) ref: https://kubernetes.io/docs/concepts/services-networking/ingress/#tls |
 | initContainers | list | `[]` | Add additional init containers to the dial-extension pod(s) ref: https://kubernetes.io/docs/concepts/workloads/pods/init-containers/ |
 | labels | object | `{}` | Labels to add to dial-extension deployed objects |
 | lifecycleHooks | object | `{}` | for the dial-extension container(s) to automate configuration before or after startup |

diff --git a/charts/dial-extension/templates/ingress.yaml b/charts/dial-extension/templates/ingress.yaml
@@ -22,7 +22,7 @@ spec:
   ingressClassName: {{ .Values.ingress.ingressClassName }}
 {{- end }}
 {{- if .Values.ingress.tls }}
-  tls: {{ toYaml .Values.ingress.tls | nindent 4 }}
+  tls: {{- include "common.tplvalues.render" (dict "value" .Values.ingress.tls "context" $) | nindent 4 }}
 {{- end }}
   rules:
   {{- range .Values.ingress.hosts }}

diff --git a/charts/dial-extension/values.yaml b/charts/dial-extension/values.yaml
@@ -394,7 +394,7 @@ ingress:
   # -- An array with hostname(s) to be covered with the ingress record
   hosts:
     - dial-extension.local
-  # -- TLS configuration for additional hostname(s) to be covered with this ingress record
+  # -- TLS configuration for additional hostname(s) to be covered with this ingress record (evaluated as a template)
   # ref: https://kubernetes.io/docs/concepts/services-networking/ingress/#tls
   tls:
     []