Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added curation for union NPM package #620

Closed
wants to merge 7 commits into from
Closed

fix: added curation for union NPM package #620

wants to merge 7 commits into from

Conversation

adubovik
Copy link
Contributor

@adubovik adubovik commented Jan 29, 2024 •
edited
Loading

As per curations doc

@adubovik
Copy link
Contributor Author

adubovik commented Jan 29, 2024 •
edited
Loading

Can't integrate curations into .ort.yml since it's prohibited:

WARNING: PACKAGE_CURATION_IN_ORT_YML - The use of package curations is not allowed in the *.ort.yml file.

Alternatively, when the curations are declared in config.yaml, ORT doesn't pick up the file, because it isn't configured to look at this conf.

@adubovik adubovik closed this Jan 29, 2024
@adubovik adubovik deleted the fix/added-union-curation branch January 29, 2024 16:36
@adubovik adubovik restored the fix/added-union-curation branch January 30, 2024 10:41
@adubovik adubovik reopened this Jan 30, 2024
@mikitabut mikitabut closed this Jan 31, 2024
@adubovik adubovik deleted the fix/added-union-curation branch January 31, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adubovik @mikitabut