refactor(filter): Simplify allocation avoidance

Cherry pick fdc4358 (assert-rs#279)
epage · May 16, 2024 · b283dd9 · b283dd9
1 parent 5c9fe2e
commit b283dd9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/crates/snapbox/src/filter/redactions.rs b/crates/snapbox/src/filter/redactions.rs
@@ -97,12 +97,12 @@ impl Redactions {
     }
 
     fn clear<'v>(&self, pattern: &'v str) -> Cow<'v, str> {
-        if pattern.contains('[') {
-            let mut pattern = Cow::Borrowed(pattern);
+        if !self.unused.is_empty() && pattern.contains('[') {
+            let mut pattern = pattern.to_owned();
             for var in self.unused.iter() {
-                pattern = Cow::Owned(pattern.replace(var, ""));
+                pattern = pattern.replace(var, "");
             }
-            pattern
+            Cow::Owned(pattern)
         } else {
             Cow::Borrowed(pattern)
         }