Additional fixes for #67 and #31 #470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that #434 didn't fully fix the issue for me.
For #67, I just added @eoyilmaz's same fix for the
direction_selectdropdown as well.From your screenshot in this comment, it looks like you loaded a profile that didn't have the LUT checkbox enabled, so setting a default for the direction wouldn't have come up. No big deal.
For #31, even after the above fix, I was still getting the
can only concatenate str (not "NoneType") to strGUI error. I eventually found that this error was coming from within theLUTFrameclass, which just needed the same fix sodirectionhas a default value there too.