Fix 3dlut gamma reset during profiling #466
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Argyll related utility classes and functions.
…n module at `DisplayCAL.argyll`.
…of `RealDisplaySizeMM` module. This needs a redesign and better implementation. But is a good proof of concept.
…ta()` now uses regular expressions to extract the data.
… output to extract EDID data. - [eoyilmaz#16] Fixed `DisplayCAL.RealDisplaySizeMM.Display.from_dispwin_data()` to expect and use `bytes` data instead of `str`. - [eoyilmaz#16] Updated `DisplayCAL.RealDisplaySizeMM.get_dispwin_output()` to return `bytes` instead of `str` to match the rest of the application.
…GitHub action.
… use predefined test data.
…and with `-d0` argument in `DisplayCAL.RealDisplaySizeMM`.
… utility to get the `xrandr` executable path under Linux.
…es of GitHub actions.
… of GitHub actions.
…ses of GitHub actions.
…ing purposes of GitHub actions.
…yCAL.dev.mocks` for a possible bug.
…ly with the mocked `xrandr` output.
…n_data()` and `DisplayCAL.RealDisplaySizeMM._enumerate_displays()` for ArgyllCMS<3.3.0 style output.
…an C-Extension.
…_output()` for Windows.
…nged with relative gamma even if user did not select custom gamma prior to changing slider.
…ub.com/Adam-Color/displaycal-py3 into fix-3dlut-gamma-reset-during-profiling
|
7129e2b : fixed the trc variable issue, but it did not solve the underlying bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #465
So far, all I've been able to figure out is that in display_cal.py, in the MainFrame() class, in update_controls(), the trc variable always returns None, meaning that the custom gamma code is never reached. Why this happens, I have not been able to figure out.
I think I found another related bug where if the offset level is changed without first setting custom gamma, the cfg values don't update, but I want someone to double-check my solution to that issue.