Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated testing environment to python 3.12 #340

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

p5k369
Copy link
Collaborator

@p5k369 p5k369 commented Mar 24, 2024

  • added python 3.12 for testing
  • updated github actions

@eoyilmaz eoyilmaz merged commit 2cca1f3 into eoyilmaz:develop Mar 24, 2024
7 of 8 checks passed
@p5k369
Copy link
Collaborator Author

p5k369 commented Mar 24, 2024

@eoyilmaz Damn. I should have marked it as not ready for merge. I build the wheels for wxpython-4.2.1 and python 3.12 and uploaded them.
But there is some problem with pytest. It has nothing to do with the tests. I think something goes wrong during import when calling pytest. Even if all tests are skipped calling python3 -m pytest will segfault, also locally. I assume it has something to do with RealDisplaySizeMM, but can't confirm that right now.

@p5k369
Copy link
Collaborator Author

p5k369 commented Mar 24, 2024

I'm 95% sure it is because of some issue with the c-extension.

@p5k369
Copy link
Collaborator Author

p5k369 commented Mar 24, 2024

I think I was wrong, seems like the segfault is bound to the import of wx into the test module.

@eoyilmaz
Copy link
Owner

Damn. I should have marked it as not ready for merge.

Aah, sorry about that.

I'm 95% sure it is because of some issue with the c-extension.

I started to think it is time to remove this c-extension. I'm going to go over it again, but as I understand it is only doing some mundane task there of finding what is the pixel equvelant of the given dimensions in mm, that is ultra unnecessary if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants